Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Firewall Manager Policies #4058

Closed
bflad opened this issue Apr 5, 2018 · 13 comments · Fixed by #9594
Closed

Feature Request: Support Firewall Manager Policies #4058

bflad opened this issue Apr 5, 2018 · 13 comments · Fixed by #9594
Labels
new-resource Introduces a new resource. service/fms Issues and PRs that pertain to the fms service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Apr 5, 2018

Amazon has released a new service, Firewall Manager, which provides centralized configuration of WAF rules across accounts and applications. https://aws.amazon.com/about-aws/whats-new/2018/04/introducing-aws-firewall-manager/

Please vote on this issue by adding a 👍 reaction to the original issue to help prioritize interest. If you're interested in implementing this feature request, please comment below.

Prerequisites:

Terraform Version

terraform 0.10+

New Resource(s)

  • aws_fms_policy

Terraform Configuration Files

# Example implementation, may change when developed
resource "aws_fms_policy" "example" {
  exclude_resource_tags = true        # Required
  name                  = "example"   # Required
  remediation_enabled   = true        # Required
  resource_tags         = ["example"] # Optional
  resource_type         = "AWS::ElasticLoadBalancingV2::LoadBalancer" # Required

  security_service_policy_data { # Required
    managed_service_data = "{}"  # Required
    type                 = "WAF" # Required
  }
}

Expected Behavior

Resource creates, updates, and deletes Firewall Manager policies.

Actual Behavior

New feature.

References

@bflad bflad added new-resource Introduces a new resource. service/fms Issues and PRs that pertain to the fms service. labels Apr 5, 2018
@hhh0505
Copy link

hhh0505 commented Jul 31, 2019

Any update on this? Would make our life much easier to have this supported

@robh007
Copy link
Contributor

robh007 commented Aug 1, 2019

I've been working on this the last week or so. I have something as a WIP I'll try and push up later today. I have a working test, however I may need to consult around set up from Organizations.

@rsclarke-vgw
Copy link

@robh007 Is this something you are continuing to work on adding:

@robh007
Copy link
Contributor

robh007 commented Mar 16, 2020

@rsclarke-vgw hi, I just needed some time to get back and look at to the original PR. By all means if you want to continue that's ok. If not I can try and put some time in over the next couple of weeks.

@derhally
Copy link

Any update? Was about to start using Firewall Manager. This looks very handy.

@rsclarke-vgw
Copy link

@derhally Apologies, not from myself. This is something I haven't pursued.

@fabioviana-hotmart
Copy link

Any update?

@breathingdust
Copy link
Member

Hi all! 👋 Just wanted to direct you to our public roadmap for this quarter (Nov-Jan) in which this item has been mentioned.

Due to the significant community interest in support for this feature, we will be looking at merging existing contributions soon.

We appreciate all the contributions and feedback thus far.

Look out for support in the provider soon!

@robh007
Copy link
Contributor

robh007 commented Nov 6, 2020

Hi, @breathingdust. Should I look too tidy up my original PR? Or shall I leave it as is?

@breathingdust
Copy link
Member

Hi @robh007, if you are able to that would be great. If things stay on track you should hear from an engineer towards the end of November.

@bee-keeper
Copy link

Any updates on this?

@bflad bflad added this to the Roadmap milestone Jan 5, 2021
@breathingdust breathingdust modified the milestones: Roadmap, v3.24.0 Jan 11, 2021
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/fms Issues and PRs that pertain to the fms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants