-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix bug where customer_encryption_key_arn was not passed in on update #39565
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…is they're deleted, always send prompt configuration on update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrockAgentAgent_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3 -run=TestAccBedrockAgentAgent_ -timeout 360m
=== RUN TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== RUN TestAccBedrockAgentAgent_full
=== PAUSE TestAccBedrockAgentAgent_full
=== RUN TestAccBedrockAgentAgent_singlePrompt
=== PAUSE TestAccBedrockAgentAgent_singlePrompt
=== RUN TestAccBedrockAgentAgent_singlePromptUpdate
=== PAUSE TestAccBedrockAgentAgent_singlePromptUpdate
=== RUN TestAccBedrockAgentAgent_addPrompt
=== PAUSE TestAccBedrockAgentAgent_addPrompt
=== RUN TestAccBedrockAgentAgent_guardrail
=== PAUSE TestAccBedrockAgentAgent_guardrail
=== RUN TestAccBedrockAgentAgent_update
=== PAUSE TestAccBedrockAgentAgent_update
=== RUN TestAccBedrockAgentAgent_tags
=== PAUSE TestAccBedrockAgentAgent_tags
=== RUN TestAccBedrockAgentAgent_kms
=== PAUSE TestAccBedrockAgentAgent_kms
=== CONT TestAccBedrockAgentAgent_basic
=== CONT TestAccBedrockAgentAgent_guardrail
=== CONT TestAccBedrockAgentAgent_tags
--- PASS: TestAccBedrockAgentAgent_basic (22.42s)
=== CONT TestAccBedrockAgentAgent_kms
--- PASS: TestAccBedrockAgentAgent_tags (39.33s)
=== CONT TestAccBedrockAgentAgent_singlePromptUpdate
--- PASS: TestAccBedrockAgentAgent_guardrail (56.53s)
=== CONT TestAccBedrockAgentAgent_addPrompt
--- PASS: TestAccBedrockAgentAgent_kms (35.22s)
=== CONT TestAccBedrockAgentAgent_singlePrompt
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (31.42s)
=== CONT TestAccBedrockAgentAgent_full
--- PASS: TestAccBedrockAgentAgent_singlePrompt (19.54s)
=== CONT TestAccBedrockAgentAgent_update
--- PASS: TestAccBedrockAgentAgent_full (29.68s)
--- PASS: TestAccBedrockAgentAgent_addPrompt (69.38s)
--- PASS: TestAccBedrockAgentAgent_update (64.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 146.497s
@drewtul Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fix bug where customer_encryption_key_arn was not passed in on update
Fix bug where prompt configuration is lost if you update a different property.
Relations
Closes #39548
References
Output from Acceptance Testing