-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_glue_trigger: fix crash when null action
is configured
#38994
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Previously a null action caused the provider to panic. Now null actions are not expanded, which may result an error from the AWS API if only null actions are present, but prevents a complete crash. Also addressed missing nil checks in the remaining expand functions for this resource. ```console % make testacc PKG=glue TESTS=TestAccGlueTrigger_Actions_null make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueTrigger_Actions_null' -timeout 360m --- PASS: TestAccGlueTrigger_Actions_null (6.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 15.712s ``` ```console % make testacc PKG=glue TESTS=TestAccGlueTrigger_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueTrigger_' -timeout 360m --- PASS: TestAccGlueTrigger_Actions_null (11.93s) --- PASS: TestAccGlueTrigger_eventBatchingCondition (64.61s) --- PASS: TestAccGlueTrigger_tags (94.60s) --- PASS: TestAccGlueTrigger_Actions_security (95.74s) --- PASS: TestAccGlueTrigger_description (99.00s) --- PASS: TestAccGlueTrigger_Actions_notify (114.73s) --- PASS: TestAccGlueTrigger_enabled (119.84s) --- PASS: TestAccGlueTrigger_workflowName (129.65s) --- PASS: TestAccGlueTrigger_crawler (134.58s) --- PASS: TestAccGlueTrigger_basic (141.46s) --- PASS: TestAccGlueTrigger_startOnCreate (152.00s) --- PASS: TestAccGlueTrigger_predicate (160.11s) --- PASS: TestAccGlueTrigger_disappears (166.73s) --- PASS: TestAccGlueTrigger_onDemandDisable (168.17s) --- PASS: TestAccGlueTrigger_schedule (173.62s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 182.908s ```
6c4cdd5
to
8197156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Previously a null action caused the provider to panic. Now null actions are not expanded, which may result an error from the AWS API if only null actions are present, but prevents a complete crash.
Also addressed missing nil checks in the remaining expand functions for this resource.
Relations
Closes #31213
Output from Acceptance Testing