Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_neptune_cluster: Fixing Issue #38979 with incorrect default value used for cluster and instance parameter group #38980

Merged
merged 8 commits into from
Aug 27, 2024
Merged

r/aws_neptune_cluster: Fixing Issue #38979 with incorrect default value used for cluster and instance parameter group #38980

merged 8 commits into from
Aug 27, 2024

Conversation

triggan
Copy link
Contributor

@triggan triggan commented Aug 22, 2024

Description

Fixing Issue #38979 where an incorrect default value was being used for
both the cluster and instance parameter group.
Changed preferred instance types for tests to use Graviton instances where possible to save on testing cost.
Updated KMS key policies used in tests as the previously used policies were overly permissive.
Fixed issue with waiting state used in tests for engine upgrades. Previous waiting functions did not take PendingModifiedValues into account when checking cluster status.

Relations

Closes #38979

References

Output from Acceptance Testing

% make testacc TESTS=TestAccNeptuneCluster PKG=neptune
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/neptune/... -v -count 1 -parallel 20 -run='TestAccNeptuneCluster'  -timeout 360m
=== RUN   TestAccNeptuneClusterEndpoint_basic
=== PAUSE TestAccNeptuneClusterEndpoint_basic
=== RUN   TestAccNeptuneClusterEndpoint_tags
=== PAUSE TestAccNeptuneClusterEndpoint_tags
=== RUN   TestAccNeptuneClusterEndpoint_disappears
=== PAUSE TestAccNeptuneClusterEndpoint_disappears
=== RUN   TestAccNeptuneClusterEndpoint_Disappears_cluster
=== PAUSE TestAccNeptuneClusterEndpoint_Disappears_cluster
=== RUN   TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== RUN   TestAccNeptuneClusterInstance_disappears
=== PAUSE TestAccNeptuneClusterInstance_disappears
=== RUN   TestAccNeptuneClusterInstance_identifierGenerated
=== PAUSE TestAccNeptuneClusterInstance_identifierGenerated
=== RUN   TestAccNeptuneClusterInstance_identifierPrefix
=== PAUSE TestAccNeptuneClusterInstance_identifierPrefix
=== RUN   TestAccNeptuneClusterInstance_tags
=== PAUSE TestAccNeptuneClusterInstance_tags
=== RUN   TestAccNeptuneClusterInstance_withAZ
=== PAUSE TestAccNeptuneClusterInstance_withAZ
=== RUN   TestAccNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccNeptuneClusterInstance_withSubnetGroup
=== RUN   TestAccNeptuneClusterInstance_kmsKey
=== PAUSE TestAccNeptuneClusterInstance_kmsKey
=== RUN   TestAccNeptuneClusterParameterGroup_basic
=== PAUSE TestAccNeptuneClusterParameterGroup_basic
=== RUN   TestAccNeptuneClusterParameterGroup_disappears
=== PAUSE TestAccNeptuneClusterParameterGroup_disappears
=== RUN   TestAccNeptuneClusterParameterGroup_nameGenerated
=== PAUSE TestAccNeptuneClusterParameterGroup_nameGenerated
=== RUN   TestAccNeptuneClusterParameterGroup_namePrefix
=== PAUSE TestAccNeptuneClusterParameterGroup_namePrefix
=== RUN   TestAccNeptuneClusterParameterGroup_tags
=== PAUSE TestAccNeptuneClusterParameterGroup_tags
=== RUN   TestAccNeptuneClusterParameterGroup_description
=== PAUSE TestAccNeptuneClusterParameterGroup_description
=== RUN   TestAccNeptuneClusterParameterGroup_parameter
=== PAUSE TestAccNeptuneClusterParameterGroup_parameter
=== RUN   TestAccNeptuneClusterParameterGroup_parameterDefault
=== PAUSE TestAccNeptuneClusterParameterGroup_parameterDefault
=== RUN   TestAccNeptuneClusterSnapshot_basic
=== PAUSE TestAccNeptuneClusterSnapshot_basic
=== RUN   TestAccNeptuneClusterSnapshot_disappears
=== PAUSE TestAccNeptuneClusterSnapshot_disappears
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_disappears
=== PAUSE TestAccNeptuneCluster_disappears
=== RUN   TestAccNeptuneCluster_identifierGenerated
=== PAUSE TestAccNeptuneCluster_identifierGenerated
=== RUN   TestAccNeptuneCluster_identifierPrefix
=== PAUSE TestAccNeptuneCluster_identifierPrefix
=== RUN   TestAccNeptuneCluster_tags
=== PAUSE TestAccNeptuneCluster_tags
=== RUN   TestAccNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccNeptuneCluster_serverlessConfiguration
=== PAUSE TestAccNeptuneCluster_serverlessConfiguration
=== RUN   TestAccNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccNeptuneCluster_updateIAMRoles
=== PAUSE TestAccNeptuneCluster_updateIAMRoles
=== RUN   TestAccNeptuneCluster_kmsKey
=== PAUSE TestAccNeptuneCluster_kmsKey
=== RUN   TestAccNeptuneCluster_encrypted
=== PAUSE TestAccNeptuneCluster_encrypted
=== RUN   TestAccNeptuneCluster_backupsUpdate
=== PAUSE TestAccNeptuneCluster_backupsUpdate
=== RUN   TestAccNeptuneCluster_iamAuth
=== PAUSE TestAccNeptuneCluster_iamAuth
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== RUN   TestAccNeptuneCluster_updateEngineVersion
=== PAUSE TestAccNeptuneCluster_updateEngineVersion
=== RUN   TestAccNeptuneCluster_updateEngineMajorVersion
=== PAUSE TestAccNeptuneCluster_updateEngineMajorVersion
=== RUN   TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccNeptuneCluster_deleteProtection
=== PAUSE TestAccNeptuneCluster_deleteProtection
=== RUN   TestAccNeptuneCluster_restoreFromSnapshot
=== PAUSE TestAccNeptuneCluster_restoreFromSnapshot
=== RUN   TestAccNeptuneCluster_storageType
=== PAUSE TestAccNeptuneCluster_storageType
=== CONT  TestAccNeptuneClusterEndpoint_basic
=== CONT  TestAccNeptuneClusterSnapshot_disappears
=== CONT  TestAccNeptuneCluster_encrypted
=== CONT  TestAccNeptuneCluster_kmsKey
=== CONT  TestAccNeptuneCluster_updateIAMRoles
=== CONT  TestAccNeptuneCluster_tags
=== CONT  TestAccNeptuneCluster_identifierPrefix
=== CONT  TestAccNeptuneCluster_identifierGenerated
=== CONT  TestAccNeptuneCluster_serverlessConfiguration
=== CONT  TestAccNeptuneCluster_takeFinalSnapshot
=== CONT  TestAccNeptuneCluster_copyTagsToSnapshot
=== CONT  TestAccNeptuneCluster_basic
=== CONT  TestAccNeptuneCluster_disappears
=== CONT  TestAccNeptuneClusterInstance_kmsKey
=== CONT  TestAccNeptuneClusterParameterGroup_tags
=== CONT  TestAccNeptuneClusterParameterGroup_namePrefix
=== CONT  TestAccNeptuneClusterSnapshot_basic
=== CONT  TestAccNeptuneClusterParameterGroup_nameGenerated
=== CONT  TestAccNeptuneClusterParameterGroup_disappears
=== CONT  TestAccNeptuneClusterParameterGroup_basic
--- PASS: TestAccNeptuneClusterParameterGroup_disappears (45.04s)
=== CONT  TestAccNeptuneCluster_updateEngineMajorVersion
--- PASS: TestAccNeptuneClusterParameterGroup_namePrefix (48.54s)
=== CONT  TestAccNeptuneCluster_storageType
--- PASS: TestAccNeptuneClusterParameterGroup_basic (49.72s)
=== CONT  TestAccNeptuneCluster_restoreFromSnapshot
--- PASS: TestAccNeptuneClusterParameterGroup_nameGenerated (50.04s)
=== CONT  TestAccNeptuneCluster_deleteProtection
--- PASS: TestAccNeptuneClusterParameterGroup_tags (64.86s)
=== CONT  TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccNeptuneCluster_disappears (148.46s)
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_encrypted (154.28s)
=== CONT  TestAccNeptuneCluster_updateEngineVersion
--- PASS: TestAccNeptuneCluster_identifierGenerated (158.66s)
=== CONT  TestAccNeptuneClusterInstance_identifierGenerated
--- PASS: TestAccNeptuneCluster_identifierPrefix (175.60s)
=== CONT  TestAccNeptuneClusterInstance_withSubnetGroup
--- PASS: TestAccNeptuneCluster_serverlessConfiguration (180.09s)
=== CONT  TestAccNeptuneClusterInstance_withAZ
--- PASS: TestAccNeptuneCluster_basic (180.15s)
=== CONT  TestAccNeptuneClusterInstance_tags
--- PASS: TestAccNeptuneClusterEndpoint_basic (201.14s)
=== CONT  TestAccNeptuneClusterInstance_identifierPrefix
--- PASS: TestAccNeptuneCluster_kmsKey (204.23s)
=== CONT  TestAccNeptuneClusterParameterGroup_parameter
--- PASS: TestAccNeptuneCluster_updateIAMRoles (220.92s)
=== CONT  TestAccNeptuneClusterParameterGroup_parameterDefault
--- PASS: TestAccNeptuneCluster_tags (220.99s)
=== CONT  TestAccNeptuneClusterParameterGroup_description
--- PASS: TestAccNeptuneClusterParameterGroup_parameter (18.10s)
=== CONT  TestAccNeptuneCluster_iamAuth
--- PASS: TestAccNeptuneClusterParameterGroup_parameterDefault (14.02s)
=== CONT  TestAccNeptuneClusterEndpoint_Disappears_cluster
--- PASS: TestAccNeptuneClusterParameterGroup_description (18.16s)
=== CONT  TestAccNeptuneClusterInstance_disappears
--- PASS: TestAccNeptuneCluster_storageType (192.47s)
=== CONT  TestAccNeptuneClusterInstance_basic
--- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (244.42s)
=== CONT  TestAccNeptuneClusterEndpoint_disappears
--- PASS: TestAccNeptuneClusterSnapshot_disappears (244.81s)
=== CONT  TestAccNeptuneClusterEndpoint_tags
--- PASS: TestAccNeptuneClusterSnapshot_basic (245.59s)
=== CONT  TestAccNeptuneCluster_backupsUpdate
--- PASS: TestAccNeptuneCluster_deleteProtection (253.96s)
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (309.88s)
--- PASS: TestAccNeptuneCluster_iamAuth (126.35s)
--- PASS: TestAccNeptuneClusterEndpoint_Disappears_cluster (166.12s)
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (264.30s)
--- PASS: TestAccNeptuneClusterEndpoint_disappears (170.35s)
--- PASS: TestAccNeptuneCluster_backupsUpdate (173.26s)
--- PASS: TestAccNeptuneClusterEndpoint_tags (209.57s)
--- PASS: TestAccNeptuneCluster_restoreFromSnapshot (453.14s)
--- PASS: TestAccNeptuneClusterInstance_kmsKey (1559.48s)
--- PASS: TestAccNeptuneClusterInstance_withAZ (1473.39s)
--- PASS: TestAccNeptuneClusterInstance_disappears (1429.74s)
--- PASS: TestAccNeptuneClusterInstance_identifierPrefix (1483.97s)
--- PASS: TestAccNeptuneClusterInstance_basic (1453.70s)
--- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (1519.14s)
--- PASS: TestAccNeptuneClusterInstance_tags (1534.99s)
--- PASS: TestAccNeptuneClusterInstance_identifierGenerated (1576.20s)
--- PASS: TestAccNeptuneCluster_updateEngineVersion (1664.44s)
--- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (2354.90s)
--- PASS: TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (3390.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    3455.409s

% make testacc TESTS=TestAccNeptuneGlobalCluster PKG=neptune
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/neptune/... -v -count 1 -parallel 20 -run='TestAccNeptuneGlobalCluster'  -timeout 360m
=== RUN   TestAccNeptuneGlobalCluster_basic
=== PAUSE TestAccNeptuneGlobalCluster_basic
=== RUN   TestAccNeptuneGlobalCluster_completeBasic
=== PAUSE TestAccNeptuneGlobalCluster_completeBasic
=== RUN   TestAccNeptuneGlobalCluster_disappears
=== PAUSE TestAccNeptuneGlobalCluster_disappears
=== RUN   TestAccNeptuneGlobalCluster_DeletionProtection
=== PAUSE TestAccNeptuneGlobalCluster_DeletionProtection
=== RUN   TestAccNeptuneGlobalCluster_Engine
=== PAUSE TestAccNeptuneGlobalCluster_Engine
=== RUN   TestAccNeptuneGlobalCluster_EngineVersion
=== PAUSE TestAccNeptuneGlobalCluster_EngineVersion
=== RUN   TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccNeptuneGlobalCluster_StorageEncrypted
=== PAUSE TestAccNeptuneGlobalCluster_StorageEncrypted
=== CONT  TestAccNeptuneGlobalCluster_basic
=== CONT  TestAccNeptuneGlobalCluster_EngineVersion
=== CONT  TestAccNeptuneGlobalCluster_StorageEncrypted
=== CONT  TestAccNeptuneGlobalCluster_Engine
=== CONT  TestAccNeptuneGlobalCluster_disappears
=== CONT  TestAccNeptuneGlobalCluster_completeBasic
=== CONT  TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== CONT  TestAccNeptuneGlobalCluster_DeletionProtection
=== CONT  TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
--- PASS: TestAccNeptuneGlobalCluster_disappears (29.04s)
--- PASS: TestAccNeptuneGlobalCluster_basic (33.05s)
--- PASS: TestAccNeptuneGlobalCluster_Engine (33.10s)
--- PASS: TestAccNeptuneGlobalCluster_StorageEncrypted (39.05s)
--- PASS: TestAccNeptuneGlobalCluster_DeletionProtection (67.79s)
--- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic (155.90s)
--- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (186.42s)
--- PASS: TestAccNeptuneGlobalCluster_completeBasic (194.18s)
--- PASS: TestAccNeptuneGlobalCluster_EngineVersion (1917.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    1917.971s

@triggan
Fixing Issue #38979 where an incorrect default value was being used for
1688837 
both the cluster and instance parameter group.
Changed preferred instance types for tests to use graviton instances
where possible to save on testing cost.
Updated KMS key policies used in test as the previously used policies
were overly permissive.
Fixed issue with waiting state used in tests for engine upgrades.
Previous waiting functions did not take PendingModifiedValues into
account when checking cluster status.
@triggan triggan requested a review from a team as a code owner August 22, 2024 00:49
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Aug 22, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2024
@ewbankkit ewbankkit self-assigned this Aug 27, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 27, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 27, 2024
ewbankkit
ewbankkit approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccNeptuneCluster_\|TestAccNeptuneClusterInstance_' PKG=neptune ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/neptune/... -v -count 1 -parallel 4  -run=TestAccNeptuneCluster_\|TestAccNeptuneClusterInstance_ -timeout 720m
=== RUN   TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== RUN   TestAccNeptuneClusterInstance_disappears
=== PAUSE TestAccNeptuneClusterInstance_disappears
=== RUN   TestAccNeptuneClusterInstance_identifierGenerated
=== PAUSE TestAccNeptuneClusterInstance_identifierGenerated
=== RUN   TestAccNeptuneClusterInstance_identifierPrefix
=== PAUSE TestAccNeptuneClusterInstance_identifierPrefix
=== RUN   TestAccNeptuneClusterInstance_tags
=== PAUSE TestAccNeptuneClusterInstance_tags
=== RUN   TestAccNeptuneClusterInstance_withAZ
=== PAUSE TestAccNeptuneClusterInstance_withAZ
=== RUN   TestAccNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccNeptuneClusterInstance_withSubnetGroup
=== RUN   TestAccNeptuneClusterInstance_kmsKey
=== PAUSE TestAccNeptuneClusterInstance_kmsKey
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_disappears
=== PAUSE TestAccNeptuneCluster_disappears
=== RUN   TestAccNeptuneCluster_identifierGenerated
=== PAUSE TestAccNeptuneCluster_identifierGenerated
=== RUN   TestAccNeptuneCluster_identifierPrefix
=== PAUSE TestAccNeptuneCluster_identifierPrefix
=== RUN   TestAccNeptuneCluster_tags
=== PAUSE TestAccNeptuneCluster_tags
=== RUN   TestAccNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccNeptuneCluster_serverlessConfiguration
=== PAUSE TestAccNeptuneCluster_serverlessConfiguration
=== RUN   TestAccNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccNeptuneCluster_updateIAMRoles
=== PAUSE TestAccNeptuneCluster_updateIAMRoles
=== RUN   TestAccNeptuneCluster_kmsKey
=== PAUSE TestAccNeptuneCluster_kmsKey
=== RUN   TestAccNeptuneCluster_encrypted
=== PAUSE TestAccNeptuneCluster_encrypted
=== RUN   TestAccNeptuneCluster_backupsUpdate
=== PAUSE TestAccNeptuneCluster_backupsUpdate
=== RUN   TestAccNeptuneCluster_iamAuth
=== PAUSE TestAccNeptuneCluster_iamAuth
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== RUN   TestAccNeptuneCluster_updateEngineVersion
=== PAUSE TestAccNeptuneCluster_updateEngineVersion
=== RUN   TestAccNeptuneCluster_updateEngineMajorVersion
=== PAUSE TestAccNeptuneCluster_updateEngineMajorVersion
=== RUN   TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccNeptuneCluster_deleteProtection
=== PAUSE TestAccNeptuneCluster_deleteProtection
=== RUN   TestAccNeptuneCluster_restoreFromSnapshot
=== PAUSE TestAccNeptuneCluster_restoreFromSnapshot
=== RUN   TestAccNeptuneCluster_storageType
=== PAUSE TestAccNeptuneCluster_storageType
=== CONT  TestAccNeptuneClusterInstance_basic
=== CONT  TestAccNeptuneCluster_serverlessConfiguration
=== CONT  TestAccNeptuneClusterInstance_kmsKey
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_serverlessConfiguration (166.55s)
=== CONT  TestAccNeptuneCluster_identifierPrefix
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (206.89s)
=== CONT  TestAccNeptuneCluster_copyTagsToSnapshot
--- PASS: TestAccNeptuneCluster_identifierPrefix (144.76s)
=== CONT  TestAccNeptuneCluster_tags
--- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (202.92s)
=== CONT  TestAccNeptuneCluster_encrypted
--- PASS: TestAccNeptuneCluster_tags (142.45s)
=== CONT  TestAccNeptuneCluster_iamAuth
--- PASS: TestAccNeptuneCluster_encrypted (125.61s)
=== CONT  TestAccNeptuneCluster_backupsUpdate
--- PASS: TestAccNeptuneCluster_iamAuth (146.50s)
=== CONT  TestAccNeptuneCluster_updateIAMRoles
--- PASS: TestAccNeptuneCluster_backupsUpdate (164.46s)
=== CONT  TestAccNeptuneCluster_kmsKey
--- PASS: TestAccNeptuneCluster_updateIAMRoles (164.44s)
=== CONT  TestAccNeptuneCluster_takeFinalSnapshot
--- PASS: TestAccNeptuneCluster_kmsKey (141.44s)
=== CONT  TestAccNeptuneCluster_disappears
--- PASS: TestAccNeptuneCluster_disappears (133.42s)
=== CONT  TestAccNeptuneCluster_identifierGenerated
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (329.82s)
=== CONT  TestAccNeptuneCluster_basic
--- PASS: TestAccNeptuneCluster_identifierGenerated (155.19s)
=== CONT  TestAccNeptuneCluster_deleteProtection
--- PASS: TestAccNeptuneCluster_basic (165.99s)
=== CONT  TestAccNeptuneCluster_storageType
--- PASS: TestAccNeptuneCluster_deleteProtection (253.93s)
=== CONT  TestAccNeptuneCluster_restoreFromSnapshot
--- PASS: TestAccNeptuneCluster_storageType (225.96s)
=== CONT  TestAccNeptuneClusterInstance_tags
--- PASS: TestAccNeptuneClusterInstance_kmsKey (1499.92s)
=== CONT  TestAccNeptuneCluster_updateEngineMajorVersion
--- PASS: TestAccNeptuneClusterInstance_basic (1540.07s)
=== CONT  TestAccNeptuneClusterInstance_withSubnetGroup
--- PASS: TestAccNeptuneCluster_restoreFromSnapshot (486.12s)
=== CONT  TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccNeptuneClusterInstance_tags (1406.56s)
=== CONT  TestAccNeptuneClusterInstance_withAZ
--- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (1389.27s)
=== CONT  TestAccNeptuneClusterInstance_identifierGenerated
--- PASS: TestAccNeptuneCluster_updateEngineMajorVersion (2068.96s)
=== CONT  TestAccNeptuneCluster_updateEngineVersion
--- PASS: TestAccNeptuneCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1601.27s)
=== CONT  TestAccNeptuneClusterInstance_identifierPrefix
--- PASS: TestAccNeptuneClusterInstance_withAZ (1435.23s)
=== CONT  TestAccNeptuneClusterInstance_disappears
--- PASS: TestAccNeptuneClusterInstance_identifierGenerated (1607.13s)
--- PASS: TestAccNeptuneCluster_updateEngineVersion (1788.13s)
--- PASS: TestAccNeptuneClusterInstance_identifierPrefix (1668.18s)
--- PASS: TestAccNeptuneClusterInstance_disappears (1533.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	5867.016s

@ewbankkit
Copy link
Contributor

@triggan Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bd58576 into hashicorp:main Aug 27, 2024
32 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 27, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.65.0
Development

Successfully merging this pull request may close these issues.

[Bug]: r/aws_neptune_cluster and r/aws_neptune_cluster_instance use incorrect default parameter group families
2 participants
@triggan @ewbankkit