Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_datazone_project: properly surface import id parsing errors #38924

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 19, 2024

Description

Previously a diagnostic was appended to the response but the method did not return, resulting in an index out of bounds error when a non-delimited value is provided as the import identifier.

Relations

Closes #38923

Output from Acceptance Testing

% make testacc PKG=datazone TESTS=TestAccDataZoneProject_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneProject_'  -timeout 360m

--- PASS: TestAccDataZoneProject_disappears (27.44s)
--- PASS: TestAccDataZoneProject_basic (29.53s)
--- PASS: TestAccDataZoneProject_update (41.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   47.580s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/datazone Issues and PRs that pertain to the datazone service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 19, 2024
@jar-b jar-b force-pushed the b-datazone-crash branch from fea2d9c to b388f74 Compare August 19, 2024 15:18
@jar-b jar-b added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Aug 19, 2024
@jar-b jar-b marked this pull request as ready for review August 19, 2024 15:19
@jar-b jar-b requested a review from a team as a code owner August 19, 2024 15:19
Previously a diagnostic was appended to the response but the method did not return, resulting in an index out of bounds error when a non-delimited value is provided as the import identifier.

```console
% make testacc PKG=datazone TESTS=TestAccDataZoneProject_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneProject_'  -timeout 360m

--- PASS: TestAccDataZoneProject_disappears (27.44s)
--- PASS: TestAccDataZoneProject_basic (29.53s)
--- PASS: TestAccDataZoneProject_update (41.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   47.580s
```
@jar-b jar-b force-pushed the b-datazone-crash branch from b388f74 to 0efb5e1 Compare August 19, 2024 15:23
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 20415d4 into main Aug 19, 2024
37 checks passed
@jar-b jar-b deleted the b-datazone-crash branch August 19, 2024 17:09
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 19, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 19, 2024
Copy link

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. documentation Introduces or discusses updates to documentation. service/datazone Issues and PRs that pertain to the datazone service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: crash when importing aws_datazone_project
2 participants