New Data Source: aws_ssoadmin_permission_sets

[gramsa49]

Description

New Data Source: aws_ssoadmin_permission_sets

Relations

Internal Feature Request ID: IPL-7043

References

The new data source, aws_ssoadmin_permission_sets, is intended to address a shortcoming with the existing data source, aws_ssoadmin_permission_set, where lookups by name result in 1 sso:ListPermissionSets and N sso:DescribePermissionSets (1 for each provisioned Permission Set).

This is problematic if you need to lookup a series of permission sets by name.
Assume 1000 permission sets are provisioned and you need to lookup 10 by name:

• 10 sso:ListPermissionSet calls
• 10,000 sso:DescribePermissionSet calls ((10 lookups by name * 1000 provisioned Permission Sets) + 10 sso:ListPermissionSets)
• 10,010 API calls total

This can be used to retrieve a list of ARNs of all permission sets, then the existing data source, aws_ssoadmin_permission_set, can be used to lookup the permission sets by ARN, which only issues a single sso:DescribePermissionSet call.

Using the same example above with the new data source:
Assume 1000 permission sets are provisioned and you need to lookup 10 by name:

• 1 sso:ListPermissionSet call
• 1000 sso:DescribePermissionSet calls (1000 lookups by ARN)
• 1001 API calls total

The data returned using this method can be converted to a map indexed by name as follows:

data "aws_ssoadmin_instances" "example" {}

data "aws_ssoadmin_permission_sets" "example" {
  instance_arn = tolist(data.aws_ssoadmin_instances.example.arns)[0]
}

data "aws_ssoadmin_permission_set" "example" {
  for_each     = data.aws_ssoadmin_permission_sets.example.arns
  instance_arn = tolist(data.aws_ssoadmin_instances.example.arns)[0]
  arn          = each.key
}

locals {
  psets_all = {
    for idx, val in data.aws_ssoadmin_permission_set.example :
    val.name => val
  }
}

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSOAdminPermissionSetsDataSource_' PKG=ssoadmin
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/ssoadmin/... -v -count 1 -parallel 20  -run=TestAccSSOAdminPermissionSetsDataSource_ -timeout 360m
=== RUN   TestAccSSOAdminPermissionSetsDataSource_basic
=== PAUSE TestAccSSOAdminPermissionSetsDataSource_basic
=== CONT  TestAccSSOAdminPermissionSetsDataSource_basic
--- PASS: TestAccSSOAdminPermissionSetsDataSource_basic (11.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	16.413s

[ewbankkit]

@gramsa49 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.