-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add upgrade_policy config block for aws_eks_cluster #38573
feat: Add upgrade_policy config block for aws_eks_cluster #38573
Conversation
Community NoteVoting for Prioritization
For Submitters
|
6e15ce3
to
37a3f4a
Compare
37a3f4a
to
ff50f7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSCluster_basic\|TestAccEKSCluster_upgradePolicy\|TestAccEKSClusterDataSource_basic' PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSCluster_basic\|TestAccEKSCluster_upgradePolicy\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN TestAccEKSCluster_upgradePolicy
=== PAUSE TestAccEKSCluster_upgradePolicy
=== CONT TestAccEKSClusterDataSource_basic
=== CONT TestAccEKSCluster_upgradePolicy
=== CONT TestAccEKSCluster_basic
--- PASS: TestAccEKSClusterDataSource_basic (657.79s)
--- PASS: TestAccEKSCluster_basic (688.11s)
--- PASS: TestAccEKSCluster_upgradePolicy (753.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 757.725s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
upgrade_policy
configuration block to theaws_eks_cluster
resource and data source.Relations
Closes #38510
References
Referred to UpgradePolicyRequest for specs.
Output from Acceptance Testing
Resource:
Data source: