fix: Fix create timestamp cmp for aws_appstream_image data source

[acwwat]

Description

This PR is to fix the create timestamp comparison logic that determines the most recent image for the aws_appstream_image data source.

Since the acceptance tests does not really check for the actual image to see whether it's the most recent, I've done a manual test by comparing the result from the following TF configuration and the console.

data "aws_appstream_image" "test" {
  name_regex  = "^AppStream-Graphics-.*-WinServer.*$"
  type        = "PUBLIC"
  most_recent = true
}

output "image_id" {
  value = data.aws_appstream_image.test.name
}

Results from re-apply after the code fix:

PS C:\working\tf-test> terraform apply
╷
│ Warning: Provider development overrides are in effect
│
│ The following provider development overrides are set in the CLI configuration:
│  - hashicorp/aws in C:\Users\Anthony\go\bin
│
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible   
│ with published releases.
╵
data.aws_appstream_image.test: Reading...
data.aws_appstream_image.test: Read complete after 0s [name=AppStream-Graphics-G5-WinServer2022-06-17-2024]

Changes to Outputs:
  ~ image_id = "AppStream-Graphics-G5-WinServer2016-06-17-2024" -> "AppStream-Graphics-G5-WinServer2022-06-17-2024"

You can apply this plan to save these new output values to the Terraform state, without changing any real infrastructure.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes


Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

image_id = "AppStream-Graphics-G5-WinServer2022-06-17-2024"

PS C:\working\tf-test>

Relations

Closes #38561

References

Referred to the source code for the aws_ecr_image data source for timestamp comparison logic.

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppStreamImageDataSource PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamImageDataSource'  -timeout 360m
=== RUN   TestAccAppStreamImageDataSource_basic
=== PAUSE TestAccAppStreamImageDataSource_basic
=== CONT  TestAccAppStreamImageDataSource_basic
--- PASS: TestAccAppStreamImageDataSource_basic (12.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  12.246s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppStreamImageDataSource_' PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/appstream/... -v -count 1 -parallel 20  -run=TestAccAppStreamImageDataSource_ -timeout 360m
=== RUN   TestAccAppStreamImageDataSource_basic
=== PAUSE TestAccAppStreamImageDataSource_basic
=== CONT  TestAccAppStreamImageDataSource_basic
--- PASS: TestAccAppStreamImageDataSource_basic (8.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	12.909s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.