-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add enhanced_metrics_config config block for aws_appsync_graphql_api #38570
feat: Add enhanced_metrics_config config block for aws_appsync_graphql_api #38570
Conversation
Community NoteVoting for Prioritization
For Submitters
|
53b7276
to
747a66a
Compare
747a66a
to
70d3d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppSync_serial/GraphQLAPI/basic\|TestAccAppSync_serial/GraphQLAPI/enhancedMetricsConfig' PKG=appsync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/appsync/... -v -count 1 -parallel 20 -run=TestAccAppSync_serial/GraphQLAPI/basic\|TestAccAppSync_serial/GraphQLAPI/enhancedMetricsConfig -timeout 360m
=== RUN TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT TestAccAppSync_serial
=== RUN TestAccAppSync_serial/GraphQLAPI
=== RUN TestAccAppSync_serial/GraphQLAPI/enhancedMetricsConfig
=== RUN TestAccAppSync_serial/GraphQLAPI/basic
--- PASS: TestAccAppSync_serial (30.53s)
--- PASS: TestAccAppSync_serial/GraphQLAPI (30.53s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/enhancedMetricsConfig (19.68s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/basic (10.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appsync 35.433s
@acwwat Thanks for the contribution 🎉 👏. |
Thank you @acwwat! |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
enhanced_metrics_config
configuration block to theaws_appsync_graphql_api
resource.Relations
Closes #38566
References
Referred to EnhancedMetricsConfig for specs.
Output from Acceptance Testing