Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_elasticache_user_group_association: add configurable timeouts #38559

Merged
merged 1 commit into from
Jul 26, 2024
Merged

r/aws_elasticache_user_group_association: add configurable timeouts #38559

merged 1 commit into from
Jul 26, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 26, 2024

Description

The default create and delete values will be 10 minutes, matching the previously hardcoded values.

Relations

Closes #38555

References

Output from Acceptance Testing

% make testacc PKG=elasticache TESTS="TestAccElastiCacheUserGroupAssociation_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUserGroupAssociation_'  -timeout 360m

--- PASS: TestAccElastiCacheUserGroupAssociation_disappears (285.34s)
--- PASS: TestAccElastiCacheUserGroupAssociation_basic (286.65s)
--- PASS: TestAccElastiCacheUserGroupAssociation_multiple (404.72s)
--- PASS: TestAccElastiCacheUserGroupAssociation_update (405.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        411.140s

@jar-b jar-b requested a review from a team as a code owner July 26, 2024 15:28
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. labels Jul 26, 2024
@jar-b
r/aws_elasticache_user_group_association: add configurable timeouts
3635bf0 
The default create and delete values will be 10 minutes, matching the previously hardcoded values.

```console
% make testacc PKG=elasticache TESTS="TestAccElastiCacheUserGroupAssociation_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUserGroupAssociation_'  -timeout 360m

--- PASS: TestAccElastiCacheUserGroupAssociation_disappears (285.34s)
--- PASS: TestAccElastiCacheUserGroupAssociation_basic (286.65s)
--- PASS: TestAccElastiCacheUserGroupAssociation_multiple (404.72s)
--- PASS: TestAccElastiCacheUserGroupAssociation_update (405.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        411.140s
```
@jar-b jar-b force-pushed the f-elasticache_user_group_association-timeouts branch from 7aa2209 to 3635bf0 Compare July 26, 2024 15:29
ewbankkit
ewbankkit approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit e69d190 into main Jul 26, 2024
39 checks passed
@jar-b jar-b deleted the f-elasticache_user_group_association-timeouts branch July 26, 2024 18:07
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 26, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 26, 2024
Update CHANGELOG.md for #38559
7346dee
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.61.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add configurable timeouts for aws_elasticache_user_group_association
2 participants
@jar-b @ewbankkit