fix: typo r_studio_package_manager_url in sagemaker domain

[felipempda]

Description

Attribute r_studio_package_manager_url in SageMaker domain shows up in Terraform plan but is not used on API calls to AWS due to a typo.

Relations

Closes #38546

References

In order to run this tests you'd need a license shared from Posit to your account: https://docs.aws.amazon.com/sagemaker/latest/dg/rstudio-license.html

Output from Acceptance Testing

Please see comments below.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @felipempda 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[felipempda]

Output from Acceptance Testing

% make testacc TESTS=TestAccDomain_rStudioServerProDomainSettings PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccDomain_rStudioServerProDomainSettings'  -timeout 360m
=== RUN   TestAccDomain_rStudioServerProDomainSettings
--- PASS: TestAccDomain_rStudioServerProDomainSettings (389.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  390.147s

...

[felipempda]

I couldn't run test if function name was lowercase:

make testacc TESTS=testAccDomain_rStudioServerProDomainSettings PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='testAccDomain_rStudioServerProDomainSettings'  -timeout 360m
testing: warning: no tests to run
PASS

Converting it now to lowercase and putting it inside Domain because of SageMaker limits. If you want to test the acceptance test, you would have to go back to previous commit: 914b99c.

I hope this is up to standards!

[deepakbshetty]

Some feedback
Would use actual package manager url for completeness https://packagemanager.posit.co/cran/latest

IMO you should use the existing base terraform code for test case and attach license manager inline policy. Do not create a new one.

@DrFaust92 if you want review this bug fix PR

[DrFaust92]

LGTM

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMaker_serial/^Domain$$/rStudioServer' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/^Domain$/rStudioServer -timeout 360m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProAppSettings
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProDomainSettings
    acctest.go:1624: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating SageMaker Domain (d-xaufbhd7ggt1): waiting for completion: unexpected state 'Failed', wanted target 'InService'. last error: ConfigurationError: Domain-level App [arn:aws:sagemaker:us-west-2:123456789012:app/d-xaufbhd7ggt1/domain-shared/RStudioServerPro/default] failed to start: [ResourceNotFoundError: No available licenses were found. Validate that a license for RStudio Workbench exists in AWS License Manager that is in Active state.].
        
          with aws_sagemaker_domain.test,
          on terraform_plugin_test.tf line 86, in resource "aws_sagemaker_domain" "test":
          86: resource "aws_sagemaker_domain" "test" {

--- PASS: TestAccSageMaker_serial (904.12s)
    --- PASS: TestAccSageMaker_serial/Domain (904.12s)
        --- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (270.94s)
        --- SKIP: TestAccSageMaker_serial/Domain/rStudioServerProDomainSettings (633.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	909.188s

[ewbankkit]

@felipempda Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.