-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/aws_cloudwatch_event_bus: Add kms_key_identifier
argument
#38492
rd/aws_cloudwatch_event_bus: Add kms_key_identifier
argument
#38492
Conversation
Community NoteVoting for Prioritization
For Submitters
|
```console % make testacc PKG=events TESTS=TestAccEventsBus_kmsKeyIdentifier make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_kmsKeyIdentifier' -timeout 360m === RUN TestAccEventsBus_kmsKeyIdentifier === PAUSE TestAccEventsBus_kmsKeyIdentifier === CONT TestAccEventsBus_kmsKeyIdentifier --- PASS: TestAccEventsBus_kmsKeyIdentifier (55.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/events 61.663s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=events TESTS=TestAccEventsBus
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus' -timeout 360m
--- PASS: TestAccEventsBus_default (2.27s)
--- PASS: TestAccEventsBusDataSource_basic (14.96s)
--- PASS: TestAccEventsBus_disappears (16.39s)
--- PASS: TestAccEventsBusPolicy_disappears (16.72s)
--- PASS: TestAccEventsBusPolicy_disappears_EventBus (16.96s)
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (20.12s)
--- PASS: TestAccEventsBusDataSource_kmsKeyIdentifier (24.75s)
--- PASS: TestAccEventsBusPolicy_basic (26.11s)
--- PASS: TestAccEventsBus_tags (33.05s)
--- PASS: TestAccEventsBus_basic (33.08s)
--- PASS: TestAccEventsBus_kmsKeyIdentifier (36.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 41.769s
Thanks for your contribution, @kamilturek! 👍 |
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
kms_key_identifier
argument to theaws_cloudwatch_event_bus
resource and data source.Relations
Closes #37531.
References
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_CreateEventBus.html
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_DescribeEventBus.html
https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_UpdateEventBus.html
Output from Acceptance Testing