-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add event_bridge_destination block for aws_sesv2_configuration_set_event_destination #38458
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…set_event_destination
ea460c9
to
dceb362
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=sesv2 TESTS=TestAccSESV2ConfigurationSetEventDestination_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSetEventDestination_' -timeout 360m
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (13.36s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination (15.78s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (22.22s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (22.68s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (23.49s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (24.29s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (106.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 112.300s
Thanks for your contribution, @acwwat! 🚀 |
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
event_destination.event_bridge_destination
block to theaws_sesv2_configuration_set_event_destination
resource to support tracking email sending activity by delivering sending events to EventBridge.I opted to use
event_bridge_destination
instead ofeventbridge_destination
since the AWSCC provider also usesevent_bridge_destination
as the arg/block name.Relations
Closes #38021
References
Referred to EventDestinationDefinition for specs.
Output from Acceptance Testing