-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add attrs related to endpoint v2 for aws_opensearch_domain #38456
feat: Add attrs related to endpoint v2 for aws_opensearch_domain #38456
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
b517d58
to
a099d5a
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
a099d5a
to
2f2e55d
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Hi there, we are actively waiting for this to be merged and released so that we can use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomain_VPC_ipAddressType\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_ipAddressType' PKG=opensearch ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearch/... -v -count 1 -parallel 2 -run=TestAccOpenSearchDomain_VPC_ipAddressType\|TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_ipAddressType -timeout 720m
=== RUN TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN TestAccOpenSearchDomain_VPC_ipAddressType
=== PAUSE TestAccOpenSearchDomain_VPC_ipAddressType
=== RUN TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== CONT TestAccOpenSearchDomain_basic
=== CONT TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomain_basic (1792.04s)
=== CONT TestAccOpenSearchDomain_VPC_ipAddressType
--- PASS: TestAccOpenSearchDomain_ipAddressType (3631.85s)
--- PASS: TestAccOpenSearchDomain_VPC_ipAddressType (5109.72s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 6909.942s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the following attributes to the
aws_opensearch_domain
resource and data source to provide access to details related to endpoint V2 for dual-stack OpenSearch domain setup:dashboard_endpoint_v2
domain_endpoint_v2_hosted_zone_id
endpoint_v2
Relations
Closes #38012
References
Referred to DomainStatus for specs. Also referred to Creating a custom endpoint for Amazon OpenSearch Service for more information about the
DomainEndpointV2HostedZoneId
attribute which also need to be added for completeness, but wasn't immediately clear how to use it since it's related to custom endpoints.Output from Acceptance Testing