[New Data Source]: aws_appstream_image #38225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
the
needs-triage
Merging to fix go mod and go sum.
…i/terraform-provider-aws into f/appstream-image-describe Merge conflict fix.
johnsonaj
reviewed
Jul 2, 2024
| if !data.Arn.IsNull() { | ||
| describeImagesInput.Arns = []string{data.Arn.ValueString()} | ||
| } | ||
| // |
johnsonaj
reviewed
Jul 2, 2024
| } | ||
| image := filteredImages[0] | ||
|
|
||
| data.Type = fwtypes.StringEnum[awstypes.VisibilityType]{}.StringEnumValue(string(image.Visibility)) |
There was a problem hiding this comment.
This can be simplified by using the following
Suggested change
| data.Type = fwtypes.StringEnum[awstypes.VisibilityType]{}.StringEnumValue(string(image.Visibility)) | |
| data.Type = fwtypes.StringEnumValue[awstypes.VisibilityType](image.Visibility) |
|
needs CHANGELOG entry |
johnsonaj
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM 🚀
% make testacc TESTS=TestAccAppStreamImageDataSource_basic PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamImageDataSource_basic' -timeout 360m
=== RUN TestAccAppStreamImageDataSource_basic
=== PAUSE TestAccAppStreamImageDataSource_basic
=== CONT TestAccAppStreamImageDataSource_basic
--- PASS: TestAccAppStreamImageDataSource_basic (9.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 15.630s
terraform-aws-provider
bot
removed
the
needs-triage
|
This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This datasource will allow practitioners to read the description of an existing AWS Appstream2.0 image with terraform.
Relations
Relates #6508
Closes #22536
References
https://docs.aws.amazon.com/appstream2/latest/APIReference/API_DescribeImages.html
Output from Acceptance Testing