-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Data Source]: aws_describe_connector #38213
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @ThomasZalewski 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good; just a few small comments.
% make testacc TESTS=TestAccTransferConnectorDataSource_basic PKG=transfer
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnectorDataSource_basic' -timeout 360m
=== RUN TestAccTransferConnectorDataSource_basic
=== PAUSE TestAccTransferConnectorDataSource_basic
=== CONT TestAccTransferConnectorDataSource_basic
--- PASS: TestAccTransferConnectorDataSource_basic (12.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 18.423s |
Co-authored-by: Adrian Johnson <[email protected]>
…rp/terraform-provider-aws into f/describe-connector-data-source
…rp/terraform-provider-aws into f/describe-connector-data-source Merging updated markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This datasource will allow practitioners to read the description of an existing AWS Transfer Family Connector with a terraform datasource.
Relations
Closes #37675
References
https://docs.aws.amazon.com/transfer/latest/userguide/API_DescribeConnector.html
Output from Acceptance Testing