Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatbot: Add slack channel configuration #38124

Merged
merged 27 commits into from
Jul 31, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jun 25, 2024

Description

Relations

Closes #37222
Relates #12304

References

Output from Acceptance Testing

Running these tests requires setting two environment variables:

  • CHATBOT_SLACK_TEAM_ID
  • CHATBOT_SLACK_CHANNEL_ID
% make t T=TestAccChatbotSlackChannelConfiguration_ K=chatbot         
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/chatbot/... -v -count 1 -parallel 20 -run='TestAccChatbotSlackChannelConfiguration_'  -timeout 360m
=== RUN   TestAccChatbotSlackChannelConfiguration_serial
=== PAUSE TestAccChatbotSlackChannelConfiguration_serial
=== CONT  TestAccChatbotSlackChannelConfiguration_serial
=== RUN   TestAccChatbotSlackChannelConfiguration_serial/basic
=== RUN   TestAccChatbotSlackChannelConfiguration_serial/disappears
--- PASS: TestAccChatbotSlackChannelConfiguration_serial (156.94s)
    --- PASS: TestAccChatbotSlackChannelConfiguration_serial/basic (80.50s)
    --- PASS: TestAccChatbotSlackChannelConfiguration_serial/disappears (76.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chatbot	159.626s

@YakDriver YakDriver requested a review from a team as a code owner June 25, 2024 21:51
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. generators Relates to code generators. service/chatbot Issues and PRs that pertain to the chatbot service. labels Jun 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 25, 2024
@YakDriver YakDriver marked this pull request as draft June 25, 2024 21:57
@YakDriver YakDriver force-pushed the f-chatbot-slack-channel-configuration branch from 49b512f to f3fa362 Compare June 26, 2024 16:24
@YakDriver YakDriver force-pushed the f-chatbot-slack-channel-configuration branch from f3fa362 to 8f742c0 Compare July 30, 2024 16:27
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@YakDriver YakDriver marked this pull request as ready for review July 30, 2024 16:28
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. labels Jul 30, 2024
@YakDriver YakDriver marked this pull request as draft July 30, 2024 16:33
@YakDriver YakDriver marked this pull request as ready for review July 30, 2024 18:46
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment on lines 427 to 420
func (data *slackChannelConfigurationResourceModel) setID() {
data.ID = data.ChatConfigurationARN
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the id attribute necessary for this resource? Or could we import from chat_configuration_arn instead and drop the redundancy?

@YakDriver YakDriver force-pushed the f-chatbot-slack-channel-configuration branch from 5d6baed to eda11ee Compare July 31, 2024 19:27
@YakDriver YakDriver merged commit d84dce6 into main Jul 31, 2024
45 checks passed
@YakDriver YakDriver deleted the f-chatbot-slack-channel-configuration branch July 31, 2024 20:22
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 31, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 31, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chatbot Issues and PRs that pertain to the chatbot service. size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_chatbot_slack_channel_configuration
2 participants