Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: fixes throughput type for managed ebs volume #38109

Merged
merged 13 commits into from
Jul 15, 2024
Merged

Bug fix: fixes throughput type for managed ebs volume #38109

merged 13 commits into from
Jul 15, 2024

Conversation

jnsaff
Copy link
Contributor

@jnsaff jnsaff commented Jun 25, 2024

Description

When specifying throughput as an attribute for the block terraform plan fails with the following error message:

│ Error: expected type of volume_configuration.0.managed_ebs_volume.0.throughput to be integer

This is an attempt to fix this issue.

Relations

Relates: #37019

References

Type definition in aws-sdk-go-v2:
https://github.com/aws/aws-sdk-go-v2/blob/main/service/ecs/types/types.go#L4174

When specifying throughput as an attribute for the block terraform plan fails with the following error message:

```
│ Error: expected type of volume_configuration.0.managed_ebs_volume.0.throughput to be integer
```
This is an attempt to fix this issue.
@jnsaff jnsaff requested a review from a team as a code owner June 25, 2024 10:13
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. labels Jun 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2024
@ewbankkit ewbankkit self-assigned this Jul 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration_basic' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSService_VolumeConfiguration_basic -timeout 360m
=== RUN   TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== CONT  TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_VolumeConfiguration_basic (59.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	64.204s

@ewbankkit
Copy link
Contributor

ewbankkit commented Jul 15, 2024

@jnsaff Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1f30c6e into hashicorp:main Jul 15, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 15, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants