-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: fixes throughput type for managed ebs volume #38109
Conversation
When specifying throughput as an attribute for the block terraform plan fails with the following error message: ``` │ Error: expected type of volume_configuration.0.managed_ebs_volume.0.throughput to be integer ``` This is an attempt to fix this issue.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration_basic' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSService_VolumeConfiguration_basic -timeout 360m
=== RUN TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== CONT TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_VolumeConfiguration_basic (59.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 64.204s
@jnsaff Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When specifying throughput as an attribute for the block terraform plan fails with the following error message:
This is an attempt to fix this issue.
Relations
Relates: #37019
References
Type definition in aws-sdk-go-v2:
https://github.com/aws/aws-sdk-go-v2/blob/main/service/ecs/types/types.go#L4174