-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/controltower_control: add parameters
attribute
#38071
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I wasn't able to get it to run but got this:
% make t T=TestAccControlTowerControl_serial K=controltower
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/controltower/... -v -count 1 -parallel 20 -run='TestAccControlTowerControl_serial' -timeout 360m
=== RUN TestAccControlTowerControl_serial
=== PAUSE TestAccControlTowerControl_serial
=== CONT TestAccControlTowerControl_serial
=== RUN TestAccControlTowerControl_serial/Control
=== RUN TestAccControlTowerControl_serial/Control/basic
controls_data_source_test.go:49: skipping since Control Tower not found
=== RUN TestAccControlTowerControl_serial/Control/disappears
controls_data_source_test.go:49: skipping since Control Tower not found
--- PASS: TestAccControlTowerControl_serial (1.56s)
--- PASS: TestAccControlTowerControl_serial/Control (1.56s)
--- SKIP: TestAccControlTowerControl_serial/Control/basic (1.24s)
--- SKIP: TestAccControlTowerControl_serial/Control/disappears (0.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/controltower 3.936s
|
||
return diags | ||
} | ||
|
||
func resourceControlUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Update makes this a lot more useful.
Co-authored-by: Dirk Avery <[email protected]>
This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #37782
References
Output from Acceptance Testing