Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/controltower_control: add parameters attribute #38071

Merged
merged 15 commits into from
Jun 24, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Relations

Closes #37782

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@johnsonaj johnsonaj requested a review from a team as a code owner June 21, 2024 16:46
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/controltower Issues and PRs that pertain to the controltower service. labels Jun 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 21, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 24, 2024
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I wasn't able to get it to run but got this:

% make t T=TestAccControlTowerControl_serial K=controltower
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/controltower/... -v -count 1 -parallel 20 -run='TestAccControlTowerControl_serial'  -timeout 360m
=== RUN   TestAccControlTowerControl_serial
=== PAUSE TestAccControlTowerControl_serial
=== CONT  TestAccControlTowerControl_serial
=== RUN   TestAccControlTowerControl_serial/Control
=== RUN   TestAccControlTowerControl_serial/Control/basic
    controls_data_source_test.go:49: skipping since Control Tower not found
=== RUN   TestAccControlTowerControl_serial/Control/disappears
    controls_data_source_test.go:49: skipping since Control Tower not found
--- PASS: TestAccControlTowerControl_serial (1.56s)
    --- PASS: TestAccControlTowerControl_serial/Control (1.56s)
        --- SKIP: TestAccControlTowerControl_serial/Control/basic (1.24s)
        --- SKIP: TestAccControlTowerControl_serial/Control/disappears (0.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/controltower	3.936s

.changelog/38071.txt Outdated Show resolved Hide resolved

return diags
}

func resourceControlUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Update makes this a lot more useful.

internal/service/controltower/control.go Show resolved Hide resolved
@johnsonaj johnsonaj merged commit bd1368a into main Jun 24, 2024
45 checks passed
@johnsonaj johnsonaj deleted the f-controltower_control_parameters branch June 24, 2024 20:31
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 24, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jun 24, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 27, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/controltower Issues and PRs that pertain to the controltower service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The required parameter AllowedRegions is missing in aws_controltower_control
2 participants