-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_networkmanager_core_network_policy_document: Add support for service insertion #38013
d/aws_networkmanager_core_network_policy_document: Add support for service insertion #38013
Conversation
…e Insertion - Phase I.
…t` values to the returned JSON document when `segment_actions.share_with_except` is configured.
…ocument-service-insertion
…e Insertion - Phase II.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_' PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_ -timeout 360m
=== RUN TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== CONT TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (9.29s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (9.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 14.854s
This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for service insertion.
Relations
Closes #37928.
Closes #31314.
Output from Acceptance Testing