-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add managed_storage_configuration block to aws_ecs_cluster #37932
feat: Add managed_storage_configuration block to aws_ecs_cluster #37932
Conversation
Community NoteVoting for Prioritization
For Submitters
|
89210f8
to
ecbc4ff
Compare
Any ETA on when this will be reviewed and merged? I have several customers looking to roll this out. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSCluster_configuration\|TestAccECSCluster_managedStorageConfiguration\|TestAccECSCluster_basic' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSCluster_configuration\|TestAccECSCluster_managedStorageConfiguration\|TestAccECSCluster_basic -timeout 360m
=== RUN TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== RUN TestAccECSCluster_managedStorageConfiguration
=== PAUSE TestAccECSCluster_managedStorageConfiguration
=== CONT TestAccECSCluster_basic
=== CONT TestAccECSCluster_managedStorageConfiguration
=== CONT TestAccECSCluster_configuration
--- PASS: TestAccECSCluster_basic (22.23s)
--- PASS: TestAccECSCluster_configuration (41.65s)
--- PASS: TestAccECSCluster_managedStorageConfiguration (55.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 60.309s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the new
managed_storage_configuration
block to theaws_ecs_cluster
resource to support ECS Fargate ephemeral storage encryption using CMK.Relations
Closes #37922
References
Referred to CreateCluster for specs and wordings.
Output from Acceptance Testing
Note:
TestAccECSCluster_managedStorageConfiguration
is a new test case.