-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codebuild: support unsetting project concurrency #37748
codebuild: support unsetting project concurrency #37748
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeBuildProject_concurrentBuildLimit' PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run=TestAccCodeBuildProject_concurrentBuildLimit -timeout 360m
=== RUN TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== CONT TestAccCodeBuildProject_concurrentBuildLimit
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (36.35s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codebuild 41.330s
@bendrucker Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Allows
aws_codebuild_projects
to removeconcurrent_build_limit
and have the concurrency value properly unset in the API.References
https://docs.aws.amazon.com/codebuild/latest/APIReference/API_UpdateProject.html#CodeBuild-UpdateProject-request-concurrentBuildLimit
Output from Acceptance Testing
I'm not able to run these tests currently:
When I get approved for an increase from AWS support I'll update this with output.