-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_sagemaker_endpoint_configuration: supports inputandoutput #37726
aws_sagemaker_endpoint_configuration: supports inputandoutput #37726
Conversation
Community NoteVoting for Prioritization
For Submitters
|
nikhil-goenka missing changelog. otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerEndpointConfiguration_dataCapture' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMakerEndpointConfiguration_dataCapture -timeout 360m
=== RUN TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== CONT TestAccSageMakerEndpointConfiguration_dataCapture
=== CONT TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput (21.87s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (24.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 29.256s
@nikhil-goenka Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
For awareness, we are attempting to implement this endpoint configuration:
We have successful builds for both capture_mode = 'Input' OR capture_mode = 'Output' however our build attempts with 'InputAndOutput' are generating this error:
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #37330
References
Output from Acceptance Testing