feat: Implement ListTags for all taggable Lightsail resources #37711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
needs-triage
acwwat
force-pushed
the
f-aws_lightsail-list_tags
branch
from
5152d20 to
7fb48bd
Compare
acwwat
force-pushed
the
f-aws_lightsail-list_tags
branch
from
7fb48bd to
cfebac1
Compare
justinretzolk
added
bug
terraform-aws-provider
bot
added
the
prioritized
johnsonaj
approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTM 🚀
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccLightsailBucket_\|TestAccLightsailCertificate_\|TestAccLightsailDistribution_\|TestAccLightsailInstance_\|TestAccLightsailKeyPair\|TestAccLightsailLoadBalancer_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run=TestAccLightsailBucket_\|TestAccLightsailCertificate_\|TestAccLightsailDistribution_\|TestAccLightsailInstance_\|TestAccLightsailKeyPair\|TestAccLightsailLoadBalancer_ -timeout 360m
instance_test.go:364: skipping test; environment variable TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE must be set. Usage: The availability zone that is outside the providers current region.
--- SKIP: TestAccLightsailInstance_availabilityZone (0.00s)
--- PASS: TestAccLightsailKeyPair_disappears (29.92s)
--- PASS: TestAccLightsailKeyPair_publicKey (30.41s)
--- PASS: TestAccLightsailKeyPair_basic (30.66s)
--- PASS: TestAccLightsailKeyPair_encrypted (30.75s)
--- PASS: TestAccLightsailKeyPair_namePrefix (30.96s)
--- PASS: TestAccLightsailBucket_basic (33.91s)
--- PASS: TestAccLightsailContainerService_publicDomainNames (5.02s)
--- PASS: TestAccLightsailKeyPair_tags (46.52s)
--- PASS: TestAccLightsailKeyPair_keyOnlyTags (47.70s)
--- PASS: TestAccLightsailInstance_basic (54.14s)
--- PASS: TestAccLightsailInstance_disappears (54.40s)
--- PASS: TestAccLightsailCertificate_keyOnlyTags (62.63s)
--- PASS: TestAccLightsailBucket_forceDelete (27.25s)
--- PASS: TestAccLightsailCertificate_disappears (43.94s)
--- PASS: TestAccLightsailInstance_IPAddressType (74.75s)
--- PASS: TestAccLightsailInstance_tags (78.14s)
--- PASS: TestAccLightsailInstance_keyOnlyTags (78.85s)
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (41.10s)
--- PASS: TestAccLightsailCertificate_basic (40.86s)
--- PASS: TestAccLightsailCertificate_subjectAlternativeNames (42.15s)
--- PASS: TestAccLightsailCertificate_tags (63.43s)
--- PASS: TestAccLightsailBucket_tags (40.98s)
--- PASS: TestAccLightsailBucket_BundleId (38.72s)
--- PASS: TestAccLightsailBucket_keyOnlyTags (41.74s)
--- PASS: TestAccLightsailBucket_disappears (25.24s)
--- PASS: TestAccLightsailInstance_name (130.31s)
--- PASS: TestAccLightsailInstance_addOn (241.45s)
--- PASS: TestAccLightsailContainerService_keyOnlyTags (277.54s)
--- PASS: TestAccLightsailContainerService_scale (343.42s)
--- PASS: TestAccLightsailContainerService_tags (277.11s)
--- PASS: TestAccLightsailLoadBalancer_serial (4977.12s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb (1378.97s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/tags (190.28s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/key_only_tags (174.43s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/basic (168.44s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/disappears (168.63s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/name (310.59s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb/health_check_path (366.61s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment (1180.22s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/basic (561.44s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/disappears (618.78s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate (879.98s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/basic (220.11s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/disappears (230.79s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records (209.04s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names (220.02s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment (225.96s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic (225.96s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy (151.93s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic (151.93s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy (1160.06s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic (370.88s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration (375.49s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled (211.81s)
--- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears (201.88s)
--- PASS: TestAccLightsailDistribution_serial (5287.40s)
--- PASS: TestAccLightsailDistribution_serial/distribution (5287.40s)
--- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (657.51s)
--- PASS: TestAccLightsailDistribution_serial/distribution/tags (353.49s)
--- PASS: TestAccLightsailDistribution_serial/distribution/keyOnlyTags (356.70s)
--- PASS: TestAccLightsailDistribution_serial/distribution/basic (337.88s)
--- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (955.63s)
--- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (649.86s)
--- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (689.41s)
--- PASS: TestAccLightsailDistribution_serial/distribution/disappears (333.62s)
--- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (953.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 5292.966s% make testacc TESTARGS='-run=TestAccLightsailContainerService_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run=TestAccLightsailContainerService_ -timeout 360m
--- PASS: TestAccLightsailContainerService_publicDomainNames (34.44s)
--- PASS: TestAccLightsailContainerService_tags (330.03s)
--- PASS: TestAccLightsailContainerService_scale (384.40s)
--- PASS: TestAccLightsailContainerService_power (404.57s)
--- PASS: TestAccLightsailContainerService_name (414.98s)
--- PASS: TestAccLightsailContainerService_isDisabled (487.33s)
--- PASS: TestAccLightsailContainerService_disappears (527.64s)
--- PASS: TestAccLightsailContainerService_privateRegistryAccess (532.87s)
--- PASS: TestAccLightsailContainerService_basic (551.51s)
--- PASS: TestAccLightsailContainerService_keyOnlyTags (555.15s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 560.854s
|
@acwwat thank you for the contribution! 🎉 |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the
ListTagsfunction to support all Lightsail resources, so that key-value tags can be applied to them without issues that was exposed in #32430 and other related issues.While running acceptance tests I found numerous unrelated issues which needed to be fixed, which was time-consuming to say the least:
NotFoundExceptionin the delete function, sodisappearstest cases were failing.aws_lightsail_databasewere using a deprecated/removed instance typemicro_1_0, which are now replaced bymicro_2_0.aws_lightsail_databasethat validate invalid schedule input were failing due to the removal of an ending period in the error message, which needed to be removed from the regex check.One last issue is that for
aws_lightsail_distribution, the create API returns a validation error for key-only tags, indicating that the value must have at least 1 character:This is not as expected according to the documentation, and since the
TagResourceAPI supports key-only tag for distributions. I've opened an AWS support case to have AWS fix theCreateDistributionAPI and updated the test case to avoid key-only tags on create for now.Relations
Closes #37652
References
Used the implementation for
aws_lightsail_instancein PR #37652 as reference.Output from Acceptance Testing
For
aws_lightsail_bucket:For
aws_lightsail_certificate:For
aws_lightsail_container_service:For
aws_lightsail_database:For
aws_lightsail_distribution:For
aws_lightsail_instance:For
aws_lightsail_key_pair:For
aws_lightsail_lb: