-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EngineLifecycleSupport #37708
EngineLifecycleSupport #37708
Conversation
Community NoteVoting for Prioritization
For Submitters
|
# Conflicts: # internal/service/rds/instance_test.go
# Conflicts: # internal/service/rds/cluster_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCluster_engineVersion\|TestAccRDSCluster_basic\|TestAccRDSCluster_engineLifecycleSupport_disabled\|TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_engineLifecycleSupport_disabled\|TestAccRDSInstance_engineLifecycleSupport_disabled\|TestAccRDSInstance_basic' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSCluster_engineVersion\|TestAccRDSCluster_basic\|TestAccRDSCluster_engineLifecycleSupport_disabled\|TestAccRDSGlobalCluster_basic\|TestAccRDSGlobalCluster_engineLifecycleSupport_disabled\|TestAccRDSInstance_engineLifecycleSupport_disabled\|TestAccRDSInstance_basic -timeout 360m
=== RUN TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN TestAccRDSCluster_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSCluster_engineLifecycleSupport_disabled
=== RUN TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== RUN TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN TestAccRDSInstance_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSInstance_engineLifecycleSupport_disabled
=== CONT TestAccRDSCluster_basic
=== CONT TestAccRDSGlobalCluster_basic
=== CONT TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSGlobalCluster_basic (14.59s)
=== CONT TestAccRDSCluster_engineLifecycleSupport_disabled
--- PASS: TestAccRDSCluster_basic (135.19s)
=== CONT TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_engineLifecycleSupport_disabled (153.87s)
=== CONT TestAccRDSInstance_basic
--- PASS: TestAccRDSCluster_engineVersion (450.52s)
=== CONT TestAccRDSInstance_engineLifecycleSupport_disabled
--- PASS: TestAccRDSInstance_basic (467.28s)
=== CONT TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
--- PASS: TestAccRDSGlobalCluster_engineLifecycleSupport_disabled (12.13s)
--- PASS: TestAccRDSInstance_engineLifecycleSupport_disabled (528.71s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1455.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1460.244s
@nikhil-goenka Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #37619
References
Output from Acceptance Testing