-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_route53_zone: permit both name
and zone_id
arguments
#37686
Conversation
Community NoteVoting for Prioritization
For Submitters
|
As part of the migration of the `route53` service to AWS SDK V2, an `ExactlyOneOf` constraint was added to the `name` and `zone_id` arguments in the `aws_route53_zone` data source. This is technically a regression as the data source functioned correctly in earlier versions when `name` is set and `zone_id` is an empty string. This change reverts the constraint and adds an acceptance test to cover this potential configuration. ```console % make testacc PKG=route53 TESTS=TestAccRoute53ZoneDataSource_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneDataSource_' -timeout 360m --- PASS: TestAccRoute53ZoneDataSource_id (91.23s) --- PASS: TestAccRoute53ZoneDataSource_name_idEmptyString (95.31s) --- PASS: TestAccRoute53ZoneDataSource_name (101.49s) --- PASS: TestAccRoute53ZoneDataSource_serviceDiscovery (102.80s) --- PASS: TestAccRoute53ZoneDataSource_vpc (126.11s) --- PASS: TestAccRoute53ZoneDataSource_tags (127.60s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 132.691s ```
fcc4378
to
cb15f51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This functionality has been released in v5.51.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
As part of the migration of the
route53
service to AWS SDK V2, anExactlyOneOf
constraint was added to thename
andzone_id
arguments in theaws_route53_zone
data source. This is technically a regression as the data source functioned correctly in earlier versions whenname
is set andzone_id
is an empty string. This change reverts the constraint and adds an acceptance test to cover this potential configuration.Relations
Closes #37683
Relates #37510
References
Output from Acceptance Testing