-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group #37484
feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group #37484
Conversation
Community NoteVoting for Prioritization
For Submitters
|
3233de7
to
7e7b002
Compare
c61cd9a
to
3b9a6db
Compare
3b9a6db
to
751bee7
Compare
I was working on a separate branch to add return of control support but realized that I am not doing myself a favor. I've decided to just add the commit to this branch/PR so both features can go in with changes to the same set of files. |
# Conflicts: # internal/service/bedrockagent/agent_action_group.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrockAgentAgentActionGroup_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3 -run=TestAccBedrockAgentAgentActionGroup_ -timeout 360m
=== RUN TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN TestAccBedrockAgentAgentActionGroup_s3APISchema
=== PAUSE TestAccBedrockAgentAgentActionGroup_s3APISchema
=== RUN TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN TestAccBedrockAgentAgentActionGroup_functionSchema
=== PAUSE TestAccBedrockAgentAgentActionGroup_functionSchema
=== RUN TestAccBedrockAgentAgentActionGroup_returnControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_returnControl
=== CONT TestAccBedrockAgentAgentActionGroup_basic
=== CONT TestAccBedrockAgentAgentActionGroup_functionSchema
=== CONT TestAccBedrockAgentAgentActionGroup_returnControl
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (40.76s)
=== CONT TestAccBedrockAgentAgentActionGroup_update
--- PASS: TestAccBedrockAgentAgentActionGroup_functionSchema (42.63s)
=== CONT TestAccBedrockAgentAgentActionGroup_s3APISchema
--- PASS: TestAccBedrockAgentAgentActionGroup_returnControl (46.52s)
--- PASS: TestAccBedrockAgentAgentActionGroup_s3APISchema (34.93s)
--- PASS: TestAccBedrockAgentAgentActionGroup_update (42.79s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 88.752s
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add support for function schema and return of control to the
aws_bedrockagent_agent_action_group
resource.The function schema change was a bit tricky as the
parameters
argument for thefunction
block is a map of objects (being the parameter detail). With help from one of the maintainers, we determined a way to define the schema properly. Consequently,parameters
is effectively a configuration block for each parameter, and what would've been the map key (and the parameter name) must now be defined using themap_block_key
argument within theparameters
block.Relations
Closes #37391
Closes #37087
References
Referred to FunctionSchema and ActionGroupExecutor for API specs.
Output from Acceptance Testing