Migrate ram resources to AWS Go SDKv2

[DanielRieske]

Description

This PR migrates ram resources to AWS SDKv2

Also fixes #37320

Note: I don't have access to an AWS account that is able to run the remainder of tests.

Note (2): Please double-check the approach for the validation fix I made on the ARN.

ValidARNCheck incorrectly accepted an empty value and didn't append an error for it, therefore an empty value would be accepted by the validator.
Because this is used for many resources, I'd like to double-check if this is the right approach.

Relations

Closes #36199
Closes #37320

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAcc' PKG=ram
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ram/... -v -count 1 -parallel 20  -run=TestAcc -timeout 360m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN   TestAccRAMPrincipalAssociation_AccountID
=== PAUSE TestAccRAMPrincipalAssociation_AccountID
=== RUN   TestAccRAMPrincipalAssociation_disappears
=== PAUSE TestAccRAMPrincipalAssociation_disappears
=== RUN   TestAccRAMPrincipalAssociation_duplicate
=== PAUSE TestAccRAMPrincipalAssociation_duplicate
=== RUN   TestAccRAMResourceAssociation_basic
=== PAUSE TestAccRAMResourceAssociation_basic
=== RUN   TestAccRAMResourceAssociation_disappears
=== PAUSE TestAccRAMResourceAssociation_disappears
=== RUN   TestAccRAMResourceAssociation_duplicate
=== PAUSE TestAccRAMResourceAssociation_duplicate
=== RUN   TestAccRAMResourceShareAccepter_basic
=== PAUSE TestAccRAMResourceShareAccepter_basic
=== RUN   TestAccRAMResourceShareAccepter_disappears
=== PAUSE TestAccRAMResourceShareAccepter_disappears
=== RUN   TestAccRAMResourceShareAccepter_resourceAssociation
=== PAUSE TestAccRAMResourceShareAccepter_resourceAssociation
=== RUN   TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN   TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN   TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== RUN   TestAccRAMResourceShareDataSource_status
=== PAUSE TestAccRAMResourceShareDataSource_status
=== RUN   TestAccRAMResourceShare_basic
=== PAUSE TestAccRAMResourceShare_basic
=== RUN   TestAccRAMResourceShare_permission
=== PAUSE TestAccRAMResourceShare_permission
=== RUN   TestAccRAMResourceShare_allowExternalPrincipals
=== PAUSE TestAccRAMResourceShare_allowExternalPrincipals
=== RUN   TestAccRAMResourceShare_name
=== PAUSE TestAccRAMResourceShare_name
=== RUN   TestAccRAMResourceShare_tags
=== PAUSE TestAccRAMResourceShare_tags
=== RUN   TestAccRAMResourceShare_disappears
=== PAUSE TestAccRAMResourceShare_disappears
=== RUN   TestAccRAMSharingWithOrganization_serial
=== PAUSE TestAccRAMSharingWithOrganization_serial
=== CONT  TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMResourceShareDataSource_tags
=== CONT  TestAccRAMResourceAssociation_duplicate
=== CONT  TestAccRAMPrincipalAssociation_duplicate
=== CONT  TestAccRAMPrincipalAssociation_disappears
=== CONT  TestAccRAMPrincipalAssociation_AccountID
=== CONT  TestAccRAMResourceShareDataSource_basic
=== CONT  TestAccRAMResourceShareAccepter_disappears
=== CONT  TestAccRAMSharingWithOrganization_serial
=== CONT  TestAccRAMResourceShareAccepter_resourceAssociation
=== CONT  TestAccRAMResourceAssociation_basic
=== RUN   TestAccRAMSharingWithOrganization_serial/basic
=== CONT  TestAccRAMResourceAssociation_disappears
=== CONT  TestAccRAMResourceShare_tags
=== CONT  TestAccRAMResourceShare_name
=== CONT  TestAccRAMResourceShare_allowExternalPrincipals
=== CONT  TestAccRAMResourceShare_disappears
=== CONT  TestAccRAMResourceShare_permission
=== CONT  TestAccRAMResourceShare_basic
=== CONT  TestAccRAMResourceShareDataSource_status
=== CONT  TestAccRAMResourceShareDataSource_resources
=== NAME  TestAccRAMResourceShareAccepter_disappears
    resource_share_accepter_test.go:81: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRAMResourceShareAccepter_disappears (0.67s)
=== CONT  TestAccRAMResourceShareAccepter_basic
    resource_share_accepter_test.go:43: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRAMResourceShareAccepter_basic (0.00s)
=== NAME  TestAccRAMPrincipalAssociation_AccountID
    principal_association_test.go:62: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRAMPrincipalAssociation_AccountID (0.67s)
=== NAME  TestAccRAMResourceShareAccepter_resourceAssociation
    resource_share_accepter_test.go:108: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRAMResourceShareAccepter_resourceAssociation (0.67s)
=== NAME  TestAccRAMPrincipalAssociation_basic
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_basic (1.10s)
=== NAME  TestAccRAMPrincipalAssociation_duplicate
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_duplicate (1.11s)
=== NAME  TestAccRAMPrincipalAssociation_disappears
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_disappears (1.12s)
=== NAME  TestAccRAMSharingWithOrganization_serial/basic
    sharing_with_organization_test.go:33: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccRAMSharingWithOrganization_serial/disappears
    sharing_with_organization_test.go:58: this AWS account must be the management account of an AWS Organization
--- PASS: TestAccRAMSharingWithOrganization_serial (1.79s)
    --- SKIP: TestAccRAMSharingWithOrganization_serial/basic (1.39s)
    --- SKIP: TestAccRAMSharingWithOrganization_serial/disappears (0.40s)
=== NAME  TestAccRAMResourceAssociation_disappears
    resource_association_test.go:56: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating RAM Resource Association (): operation error RAM: AssociateResourceShare, https response error StatusCode: 400, RequestID: d3fea20c-38a0-438f-ad07-e1126f826c46, InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test,
          on terraform_plugin_test.tf line 46, in resource "aws_ram_resource_association" "test":
          46: resource "aws_ram_resource_association" "test" {
        
=== NAME  TestAccRAMResourceAssociation_basic
    resource_association_test.go:29: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating RAM Resource Association (): operation error RAM: AssociateResourceShare, https response error StatusCode: 400, RequestID: d01e943f-f8bd-4405-8e28-97d8d19a466b, InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test,
          on terraform_plugin_test.tf line 46, in resource "aws_ram_resource_association" "test":
          46: resource "aws_ram_resource_association" "test" {
        
=== NAME  TestAccRAMResourceShareDataSource_resources
    resource_share_data_source_test.go:78: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating RAM Resource Association (): operation error RAM: AssociateResourceShare, https response error StatusCode: 400, RequestID: f9d23a59-cc0f-4656-bf5b-bb2a82513bf6, InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test,
          on terraform_plugin_test.tf line 46, in resource "aws_ram_resource_association" "test":
          46: resource "aws_ram_resource_association" "test" {
        
=== NAME  TestAccRAMResourceAssociation_duplicate
    resource_association_test.go:78: Step 1/1, expected an error with pattern, no match on: Error running apply: exit status 1
        
        Error: creating RAM Resource Association (): operation error RAM: AssociateResourceShare, https response error StatusCode: 400, RequestID: bf44f6e8-7441-400d-9237-aabe8f2f8950, InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test1,
          on terraform_plugin_test.tf line 46, in resource "aws_ram_resource_association" "test1":
          46: resource "aws_ram_resource_association" "test1" {
        
--- FAIL: TestAccRAMResourceAssociation_basic (24.83s)
--- FAIL: TestAccRAMResourceShareDataSource_resources (24.98s)
--- FAIL: TestAccRAMResourceAssociation_duplicate (25.43s)
--- FAIL: TestAccRAMResourceAssociation_disappears (25.43s)
--- PASS: TestAccRAMResourceShareDataSource_status (31.80s)
--- PASS: TestAccRAMResourceShareDataSource_basic (32.12s)
--- PASS: TestAccRAMResourceShare_disappears (32.27s)
--- PASS: TestAccRAMResourceShare_permission (34.51s)
--- PASS: TestAccRAMResourceShare_basic (35.58s)
--- PASS: TestAccRAMResourceShareDataSource_tags (44.26s)
--- PASS: TestAccRAMResourceShare_allowExternalPrincipals (49.20s)
--- PASS: TestAccRAMResourceShare_name (49.29s)
--- PASS: TestAccRAMResourceShare_tags (59.69s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ram        63.856s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRAM' PKG=ram ACCTEST_PARALLELISM=3               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ram/... -v -count 1 -parallel 3  -run=TestAccRAM -timeout 360m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN   TestAccRAMPrincipalAssociation_AccountID
=== PAUSE TestAccRAMPrincipalAssociation_AccountID
=== RUN   TestAccRAMPrincipalAssociation_disappears
=== PAUSE TestAccRAMPrincipalAssociation_disappears
=== RUN   TestAccRAMPrincipalAssociation_duplicate
=== PAUSE TestAccRAMPrincipalAssociation_duplicate
=== RUN   TestAccRAMResourceAssociation_basic
=== PAUSE TestAccRAMResourceAssociation_basic
=== RUN   TestAccRAMResourceAssociation_disappears
=== PAUSE TestAccRAMResourceAssociation_disappears
=== RUN   TestAccRAMResourceAssociation_duplicate
=== PAUSE TestAccRAMResourceAssociation_duplicate
=== RUN   TestAccRAMResourceShareAccepter_basic
=== PAUSE TestAccRAMResourceShareAccepter_basic
=== RUN   TestAccRAMResourceShareAccepter_disappears
=== PAUSE TestAccRAMResourceShareAccepter_disappears
=== RUN   TestAccRAMResourceShareAccepter_resourceAssociation
=== PAUSE TestAccRAMResourceShareAccepter_resourceAssociation
=== RUN   TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN   TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN   TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== RUN   TestAccRAMResourceShareDataSource_status
=== PAUSE TestAccRAMResourceShareDataSource_status
=== RUN   TestAccRAMResourceShare_basic
=== PAUSE TestAccRAMResourceShare_basic
=== RUN   TestAccRAMResourceShare_permission
=== PAUSE TestAccRAMResourceShare_permission
=== RUN   TestAccRAMResourceShare_allowExternalPrincipals
=== PAUSE TestAccRAMResourceShare_allowExternalPrincipals
=== RUN   TestAccRAMResourceShare_name
=== PAUSE TestAccRAMResourceShare_name
=== RUN   TestAccRAMResourceShare_tags
=== PAUSE TestAccRAMResourceShare_tags
=== RUN   TestAccRAMResourceShare_disappears
=== PAUSE TestAccRAMResourceShare_disappears
=== RUN   TestAccRAMSharingWithOrganization_serial
=== PAUSE TestAccRAMSharingWithOrganization_serial
=== CONT  TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMResourceShareDataSource_tags
=== CONT  TestAccRAMResourceShare_allowExternalPrincipals
=== NAME  TestAccRAMPrincipalAssociation_basic
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_basic (0.57s)
=== CONT  TestAccRAMSharingWithOrganization_serial
=== RUN   TestAccRAMSharingWithOrganization_serial/basic
--- PASS: TestAccRAMResourceShareDataSource_tags (23.72s)
=== CONT  TestAccRAMResourceShare_disappears
--- PASS: TestAccRAMResourceShare_allowExternalPrincipals (24.45s)
=== CONT  TestAccRAMResourceShare_tags
=== RUN   TestAccRAMSharingWithOrganization_serial/disappears
--- PASS: TestAccRAMResourceShare_disappears (12.95s)
=== CONT  TestAccRAMResourceShare_name
--- PASS: TestAccRAMSharingWithOrganization_serial (45.95s)
    --- PASS: TestAccRAMSharingWithOrganization_serial/basic (24.39s)
    --- PASS: TestAccRAMSharingWithOrganization_serial/disappears (21.55s)
=== CONT  TestAccRAMResourceShare_basic
--- PASS: TestAccRAMResourceShare_tags (32.01s)
=== CONT  TestAccRAMResourceShare_permission
--- PASS: TestAccRAMResourceShare_name (23.20s)
=== CONT  TestAccRAMResourceShareDataSource_status
--- PASS: TestAccRAMResourceShare_basic (14.27s)
=== CONT  TestAccRAMResourceAssociation_duplicate
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMResourceAssociation_duplicate (0.04s)
=== CONT  TestAccRAMResourceShareDataSource_basic
--- PASS: TestAccRAMResourceShare_permission (14.79s)
=== CONT  TestAccRAMResourceShareAccepter_resourceAssociation
--- PASS: TestAccRAMResourceShareDataSource_status (14.03s)
=== CONT  TestAccRAMResourceShareDataSource_resources
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMResourceShareDataSource_resources (0.07s)
=== CONT  TestAccRAMResourceShareAccepter_disappears
--- PASS: TestAccRAMResourceShareDataSource_basic (14.18s)
=== CONT  TestAccRAMResourceShareAccepter_basic
--- PASS: TestAccRAMResourceShareAccepter_basic (27.41s)
=== CONT  TestAccRAMPrincipalAssociation_duplicate
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_duplicate (0.05s)
=== CONT  TestAccRAMPrincipalAssociation_disappears
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMPrincipalAssociation_disappears (0.06s)
=== CONT  TestAccRAMResourceAssociation_disappears
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMResourceAssociation_disappears (0.05s)
=== CONT  TestAccRAMPrincipalAssociation_AccountID
--- PASS: TestAccRAMResourceShareAccepter_resourceAssociation (32.66s)
=== CONT  TestAccRAMResourceAssociation_basic
    principal_association_test.go:139: Sharing with AWS Organization not found, skipping acceptance test: reading IAM Role (AWSServiceRoleForResourceAccessManager): couldn't find resource
--- SKIP: TestAccRAMResourceAssociation_basic (0.06s)
--- PASS: TestAccRAMPrincipalAssociation_AccountID (20.08s)
--- PASS: TestAccRAMResourceShareAccepter_disappears (142.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	221.099s

% make testacc TESTARGS='-run=TestAccRAMResourceAssociation_\|TestAccRAMPrincipalAssociation_\|TestAccRAMResourceShareDataSource_resources' PKG=ram ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ram/... -v -count 1 -parallel 3  -run=TestAccRAMResourceAssociation_\|TestAccRAMPrincipalAssociation_\|TestAccRAMResourceShareDataSource_resources -timeout 360m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN   TestAccRAMPrincipalAssociation_AccountID
=== PAUSE TestAccRAMPrincipalAssociation_AccountID
=== RUN   TestAccRAMPrincipalAssociation_disappears
=== PAUSE TestAccRAMPrincipalAssociation_disappears
=== RUN   TestAccRAMPrincipalAssociation_duplicate
=== PAUSE TestAccRAMPrincipalAssociation_duplicate
=== RUN   TestAccRAMResourceAssociation_basic
=== PAUSE TestAccRAMResourceAssociation_basic
=== RUN   TestAccRAMResourceAssociation_disappears
=== PAUSE TestAccRAMResourceAssociation_disappears
=== RUN   TestAccRAMResourceAssociation_duplicate
=== PAUSE TestAccRAMResourceAssociation_duplicate
=== RUN   TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== CONT  TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMResourceAssociation_basic
=== CONT  TestAccRAMPrincipalAssociation_disappears
--- PASS: TestAccRAMPrincipalAssociation_disappears (18.73s)
=== CONT  TestAccRAMPrincipalAssociation_duplicate
--- PASS: TestAccRAMPrincipalAssociation_basic (20.88s)
=== CONT  TestAccRAMPrincipalAssociation_AccountID
--- PASS: TestAccRAMResourceAssociation_basic (23.30s)
=== CONT  TestAccRAMResourceAssociation_duplicate
--- PASS: TestAccRAMPrincipalAssociation_duplicate (13.08s)
=== CONT  TestAccRAMResourceShareDataSource_resources
--- PASS: TestAccRAMResourceAssociation_duplicate (14.26s)
=== CONT  TestAccRAMResourceAssociation_disappears
--- PASS: TestAccRAMPrincipalAssociation_AccountID (22.42s)
--- PASS: TestAccRAMResourceShareDataSource_resources (23.29s)
--- PASS: TestAccRAMResourceAssociation_disappears (20.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	62.269s

[ewbankkit]

@DanielRieske Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.