-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes aws_lb_listener datasource's default_action's target_group_arn #37348
Fixes aws_lb_listener datasource's default_action's target_group_arn #37348
Conversation
…not filled in an aws_lb_listener datasource
Community NoteVoting for Prioritization
For Submitters
|
@gdavison This fix messes with your recent PR (mentioned in the description), please give some sanity check if you have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_\|TestAccELBV2Listener_Network_basic\|TestAccELBV2Listener_updateForwardBasic\|TestAccELBV2Listener_forwardWeighted' PKG=elbv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elbv2/... -v -count 1 -parallel 3 -run=TestAccELBV2ListenerDataSource_\|TestAccELBV2Listener_Network_basic\|TestAccELBV2Listener_updateForwardBasic\|TestAccELBV2Listener_forwardWeighted -timeout 360m
=== RUN TestAccELBV2ListenerDataSource_tags
=== PAUSE TestAccELBV2ListenerDataSource_tags
=== RUN TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== RUN TestAccELBV2Listener_Network_basic
=== PAUSE TestAccELBV2Listener_Network_basic
=== RUN TestAccELBV2Listener_updateForwardBasic
=== PAUSE TestAccELBV2Listener_updateForwardBasic
=== RUN TestAccELBV2Listener_forwardWeighted
=== PAUSE TestAccELBV2Listener_forwardWeighted
=== CONT TestAccELBV2ListenerDataSource_tags
=== CONT TestAccELBV2Listener_updateForwardBasic
=== CONT TestAccELBV2Listener_Network_basic
--- PASS: TestAccELBV2ListenerDataSource_tags (191.72s)
=== CONT TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2Listener_updateForwardBasic (224.24s)
=== CONT TestAccELBV2Listener_forwardWeighted
--- PASS: TestAccELBV2Listener_Network_basic (235.71s)
--- PASS: TestAccELBV2ListenerDataSource_basic (202.20s)
--- PASS: TestAccELBV2Listener_forwardWeighted (249.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 478.246s
@tmarlok88 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fixes #36459 where the default_action's target_group_arn is not filled in an aws_lb_listener datasource
Description
The default_action.target_group_arn attribute in an aws_lb_listener data source is empty.
Relations
Closes #36459
References
The bug was introduced in this PR: #35671
Output from Acceptance Testing