Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes aws_lb_listener datasource's default_action's target_group_arn #37348

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

tmarlok88
Copy link
Contributor

Fixes #36459 where the default_action's target_group_arn is not filled in an aws_lb_listener datasource

Description

The default_action.target_group_arn attribute in an aws_lb_listener data source is empty.

Relations

Closes #36459

References

The bug was introduced in this PR: #35671

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_basic' PKG=elbv2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2ListenerDataSource_basic -timeout 360m
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== CONT  TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2ListenerDataSource_basic (228.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	228.617s

...

…not filled in an aws_lb_listener datasource
Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
@tmarlok88 tmarlok88 changed the title Fixes #36459 where the default_action's target_group_arn is not fille… Fixes aws_lb_listener datasource's default_action's target_group_arn May 8, 2024
@tmarlok88
Copy link
Contributor Author

@gdavison This fix messes with your recent PR (mentioned in the description), please give some sanity check if you have the time.

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 12, 2024
@ewbankkit ewbankkit self-assigned this Jul 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_\|TestAccELBV2Listener_Network_basic\|TestAccELBV2Listener_updateForwardBasic\|TestAccELBV2Listener_forwardWeighted' PKG=elbv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2ListenerDataSource_\|TestAccELBV2Listener_Network_basic\|TestAccELBV2Listener_updateForwardBasic\|TestAccELBV2Listener_forwardWeighted -timeout 360m
=== RUN   TestAccELBV2ListenerDataSource_tags
=== PAUSE TestAccELBV2ListenerDataSource_tags
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== RUN   TestAccELBV2Listener_Network_basic
=== PAUSE TestAccELBV2Listener_Network_basic
=== RUN   TestAccELBV2Listener_updateForwardBasic
=== PAUSE TestAccELBV2Listener_updateForwardBasic
=== RUN   TestAccELBV2Listener_forwardWeighted
=== PAUSE TestAccELBV2Listener_forwardWeighted
=== CONT  TestAccELBV2ListenerDataSource_tags
=== CONT  TestAccELBV2Listener_updateForwardBasic
=== CONT  TestAccELBV2Listener_Network_basic
--- PASS: TestAccELBV2ListenerDataSource_tags (191.72s)
=== CONT  TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2Listener_updateForwardBasic (224.24s)
=== CONT  TestAccELBV2Listener_forwardWeighted
--- PASS: TestAccELBV2Listener_Network_basic (235.71s)
--- PASS: TestAccELBV2ListenerDataSource_basic (202.20s)
--- PASS: TestAccELBV2Listener_forwardWeighted (249.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	478.246s

@ewbankkit ewbankkit requested a review from a team as a code owner July 12, 2024 19:32
@ewbankkit
Copy link
Contributor

@tmarlok88 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1b31b73 into hashicorp:main Jul 12, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
@tmarlok88 tmarlok88 deleted the b-36459_lb_listener_datasource branch July 15, 2024 11:22
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_lb_listener Datastore's default_action is not filled if the type is forward
2 participants