Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_vpc_endpoint_service_private_dns_verification: new resource #37176

Merged
merged 3 commits into from
May 17, 2024
Merged

r/aws_vpc_endpoint_service_private_dns_verification: new resource #37176

merged 3 commits into from
May 17, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Apr 30, 2024 •
edited
Loading

Description

This resource will allow practitioners to start the verification process for a VPC endpoint service private DNS name via Terraform.

Relations

Closes #37163

References

Output from Acceptance Testing

% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServicePrivateDNSVerification_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServicePrivateDNSVerification_'  -timeout 360m

--- PASS: TestAccVPCEndpointServicePrivateDNSVerification_basic (218.59s)
--- PASS: TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification (262.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        267.248s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. labels Apr 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 30, 2024
@jar-b jar-b force-pushed the f-vpces-private_dns_verification branch 4 times, most recently from 66f968c to b04f735 Compare April 30, 2024 14:30
@jar-b jar-b changed the title r/aws_vpc_endpoint_private_dns_verification: new resource r/aws_vpc_endpoint_service_private_dns_verification: new resource Apr 30, 2024
@jar-b jar-b force-pushed the f-vpces-private_dns_verification branch from b04f735 to c9ed42e Compare April 30, 2024 14:38
@jar-b jar-b marked this pull request as ready for review April 30, 2024 15:30
ewbankkit
ewbankkit reviewed May 2, 2024
View reviewed changes
internal/service/ec2/vpc_endpoint_private_dns_verification.go Outdated
)
return
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it makes sense to poll on PrivateDnsNameConfiguration.State == "verified"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this requires some other DNS registration bits which may or may not use AWS Route53, my initial thinking was not to poll. Maybe it makes sense to add an optional argument (wait_for_verified_status?) so users can opt-in to this behavior if desired?

I'll think on this one a bit more.

Copy link
Member Author

@jar-b jar-b May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started implementing an optional wait_for_verification argument, and realized this can share the finder from the aws_vpc_endpoint_service resource. I have another WIP PR that migrates this resource to AWS SDK V2, which will make it usable for this purpose. I'm going to move this back into draft state and finish once that migration is complete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an optional wait_for_verification argument.

@jar-b jar-b force-pushed the f-vpces-private_dns_verification branch 4 times, most recently from 19cfb11 to 6b49c7e Compare May 13, 2024 13:00
@jar-b jar-b marked this pull request as draft May 13, 2024 13:24
jar-b added 2 commits May 17, 2024 11:53
@jar-b
internal/framework: add WithNoOpRead struct
840fd87 
This can be embedded in framework resources which do not require custom read operations.
@jar-b
internal/framework: tidy WithNoOpDelete godoc
03f6641
@jar-b jar-b force-pushed the f-vpces-private_dns_verification branch 2 times, most recently from 41abde1 to a3f0b1a Compare May 17, 2024 16:02
@jar-b
r/aws_vpc_endpoint_service_private_dns_verification: new resource
793b8e6 
This resource will allow practitioners to start the verification process for a VPC endpoint service private DNS name via Terraform.

```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServicePrivateDNSVerification_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServicePrivateDNSVerification_'  -timeout 360m

--- PASS: TestAccVPCEndpointServicePrivateDNSVerification_basic (218.59s)
--- PASS: TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification (262.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        267.248s
```
@jar-b jar-b force-pushed the f-vpces-private_dns_verification branch from a3f0b1a to 793b8e6 Compare May 17, 2024 16:05
@jar-b jar-b marked this pull request as ready for review May 17, 2024 17:01
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 17, 2024
@jar-b jar-b merged commit 087ccb9 into main May 17, 2024
62 checks passed
@jar-b jar-b deleted the f-vpces-private_dns_verification branch May 17, 2024 17:05
@github-actions github-actions bot added this to the v5.51.0 milestone May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
Update CHANGELOG.md for #37176
8bae048
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.51.0
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_vpc_endpoint_service_private_dns_verification
2 participants
@jar-b @ewbankkit