Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASG] fix: Fixed max_group_prepared_capacity to allow setting 0 #37174

Conversation

ponkio-o
Copy link
Contributor

Description

Hi, I fixed a bug in ASG warm poll settings where "Warm poll size" could not be set to 0.
The API allows "MaxGroupPreparedCapacity" to be set to 0. In fact, it can be set on the management console.
CleanShot 2024-04-30 at 17 11 17

Relations

Closes: #37173

References

https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_PutWarmPool.html#API_PutWarmPool_RequestParameters

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_warmPool' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_warmPool -timeout 360m
=== RUN   TestAccAutoScalingGroup_warmPool
=== PAUSE TestAccAutoScalingGroup_warmPool
=== CONT  TestAccAutoScalingGroup_warmPool
--- PASS: TestAccAutoScalingGroup_warmPool (495.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        500.164s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Apr 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner June 18, 2024 13:41
@ewbankkit ewbankkit self-assigned this Jun 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_warmPool\|TestAccAutoScalingGroup_basic' PKG=autoscaling ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingGroup_warmPool\|TestAccAutoScalingGroup_basic -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_warmPool
=== PAUSE TestAccAutoScalingGroup_warmPool
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_warmPool
--- PASS: TestAccAutoScalingGroup_basic (55.63s)
--- PASS: TestAccAutoScalingGroup_warmPool (547.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	552.146s

@ewbankkit ewbankkit merged commit 0a9c5af into hashicorp:main Jun 18, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 18, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 20, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ponkio-o ponkio-o deleted the fix-asg/warm_pool-max_group_prepared_capacity branch July 7, 2024 15:44
Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't set warm_pool.max_group_prepared_capacity of aws_autoscaling_group to 0
3 participants