-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASG] fix: Fixed max_group_prepared_capacity
to allow setting 0
#37174
[ASG] fix: Fixed max_group_prepared_capacity
to allow setting 0
#37174
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…roup_prepared_capacity` and `warm_pool.min_size`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_warmPool\|TestAccAutoScalingGroup_basic' PKG=autoscaling ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/autoscaling/... -v -count 1 -parallel 3 -run=TestAccAutoScalingGroup_warmPool\|TestAccAutoScalingGroup_basic -timeout 360m
=== RUN TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN TestAccAutoScalingGroup_warmPool
=== PAUSE TestAccAutoScalingGroup_warmPool
=== CONT TestAccAutoScalingGroup_basic
=== CONT TestAccAutoScalingGroup_warmPool
--- PASS: TestAccAutoScalingGroup_basic (55.63s)
--- PASS: TestAccAutoScalingGroup_warmPool (547.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 552.146s
This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Hi, I fixed a bug in ASG warm poll settings where "Warm poll size" could not be set to 0.
The API allows "MaxGroupPreparedCapacity" to be set to 0. In fact, it can be set on the management console.
Relations
Closes: #37173
References
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_PutWarmPool.html#API_PutWarmPool_RequestParameters
Output from Acceptance Testing