Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_msk_replicator:Argument for Replication starting position #36968

Merged
merged 15 commits into from
Jul 15, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 17, 2024

Description

Relations

Closes #36850

References

Output from Acceptance Testing

% make testacc TESTS=TestAccKafkaReplicator_basic PKG=kafka       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/kafka/... -v -count 1 -parallel 20 -run='TestAccKafkaReplicator_basic'  -timeout 360m
=== RUN   TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== CONT  TestAccKafkaReplicator_basic
--- PASS: TestAccKafkaReplicator_basic (6256.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	6272.142s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafka Issues and PRs that pertain to the kafka service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2024
@nikhil-goenka nikhil-goenka marked this pull request as draft April 17, 2024 21:11
@nikhil-goenka nikhil-goenka marked this pull request as ready for review April 20, 2024 13:57
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 20, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2024
@michaelgeorgeattard
Copy link

Hello! Any updates on this PR?

@sappusaketh
Copy link

Any updates? we are waiting for this feature

@ewbankkit ewbankkit self-assigned this Jul 15, 2024
# Conflicts:
#	internal/service/kafka/replicator_test.go
@ewbankkit ewbankkit requested a review from a team as a code owner July 15, 2024 18:57
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKafkaReplicator_basic\|TestAccKafkaReplicator_update' PKG=kafka
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/kafka/... -v -count 1 -parallel 20  -run=TestAccKafkaReplicator_basic\|TestAccKafkaReplicator_update -timeout 360m
=== RUN   TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== RUN   TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== CONT  TestAccKafkaReplicator_basic
=== CONT  TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_basic (7163.25s)
--- PASS: TestAccKafkaReplicator_update (7957.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	7962.227s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5840bf8 into hashicorp:main Jul 15, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 15, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_msk_replicator branch July 16, 2024 16:59
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Argument for Replication starting position in aws_msk_replicator
5 participants