Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_bedrockagent_agent_action_group #36935

Merged
merged 33 commits into from
Apr 19, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Apr 16, 2024

Description

New resource to manager AWS Bedrock Agents Action Groups

Relations

Depends on #36905

Output from Acceptance Testing

%  make testacc TESTS=TestAccBedrockAgentActionGroup_ PKG=bedrockagent
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentActionGroup_'  -timeout 360m
=== RUN   TestAccBedrockAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentActionGroup_basic
=== RUN   TestAccBedrockAgentActionGroup_s3APISchema
=== PAUSE TestAccBedrockAgentActionGroup_s3APISchema
=== RUN   TestAccBedrockAgentActionGroup_update
=== PAUSE TestAccBedrockAgentActionGroup_update
=== CONT  TestAccBedrockAgentActionGroup_basic
=== CONT  TestAccBedrockAgentActionGroup_update
=== CONT  TestAccBedrockAgentActionGroup_s3APISchema
--- PASS: TestAccBedrockAgentActionGroup_basic (41.85s)
--- PASS: TestAccBedrockAgentActionGroup_s3APISchema (48.99s)
--- PASS: TestAccBedrockAgentActionGroup_update (52.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       57.169s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels Apr 16, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Apr 16, 2024
@drewtul drewtul marked this pull request as ready for review April 17, 2024 09:22
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 19, 2024
@ewbankkit ewbankkit self-assigned this Apr 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
# Conflicts:
#	internal/service/bedrockagent/exports_test.go
@ewbankkit ewbankkit mentioned this pull request Apr 19, 2024
6 tasks
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrockAgentActionGroup_' PKG=bedrockagent ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/bedrockagent/... -v -count 1 -parallel 2  -run=TestAccBedrockAgentActionGroup_ -timeout 360m
=== RUN   TestAccBedrockAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentActionGroup_basic
=== RUN   TestAccBedrockAgentActionGroup_s3APISchema
=== PAUSE TestAccBedrockAgentActionGroup_s3APISchema
=== RUN   TestAccBedrockAgentActionGroup_update
=== PAUSE TestAccBedrockAgentActionGroup_update
=== CONT  TestAccBedrockAgentActionGroup_basic
=== CONT  TestAccBedrockAgentActionGroup_update
--- PASS: TestAccBedrockAgentActionGroup_basic (38.66s)
=== CONT  TestAccBedrockAgentActionGroup_s3APISchema
--- PASS: TestAccBedrockAgentActionGroup_update (66.07s)
--- PASS: TestAccBedrockAgentActionGroup_s3APISchema (38.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	89.349s

@ewbankkit ewbankkit merged commit d0e6765 into hashicorp:main Apr 19, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 19, 2024
@drewtul drewtul deleted the f-aws_bedrock_agent_action_group branch April 19, 2024 19:08
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. partner Contribution from a partner. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants