Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding iam_identity_center_instance_arn attribute #36830

Merged

Conversation

josnabattula
Copy link

Description

This pull request is to adding new attribute iam_identity_center_instance_arn to resource typeaws_quicksight_account_subscription to able to configure from terraform

Relations

If your pull request fully resolves and should automatically close the linked issue, use Closes. Otherwise, use Relates.

Closes #36782

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/quicksight Issues and PRs that pertain to the quicksight service. labels Apr 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 10, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
@josnabattula
Copy link
Author

@justinretzolk how this pull request gets any reviews? At the moment it is showing "no reviews"

@nam054 nam054 self-assigned this Jun 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 13, 2024
@nam054 nam054 requested a review from a team as a code owner June 25, 2024 00:14
@nam054 nam054 force-pushed the f-aws_quicksight_account_subscription-36782 branch from 536325a to d67ad54 Compare June 26, 2024 00:39
@nam054 nam054 force-pushed the f-aws_quicksight_account_subscription-36782 branch from d67ad54 to 0b5c5dc Compare June 26, 2024 18:50
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

=== RUN   TestAccQuickSight_serial
=== PAUSE TestAccQuickSight_serial
=== CONT  TestAccQuickSight_serial
=== RUN   TestAccQuickSight_serial/AccountSubscription
=== RUN   TestAccQuickSight_serial/AccountSubscription/basic
=== RUN   TestAccQuickSight_serial/AccountSubscription/disappears
--- PASS: TestAccQuickSight_serial (326.47s)
    --- PASS: TestAccQuickSight_serial/AccountSubscription (326.47s)
        --- PASS: TestAccQuickSight_serial/AccountSubscription/basic (165.25s)
        --- PASS: TestAccQuickSight_serial/AccountSubscription/disappears (161.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 330.717s

@nam054 nam054 merged commit 02adf91 into hashicorp:main Jun 26, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 27, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@josnabattula josnabattula deleted the f-aws_quicksight_account_subscription-36782 branch June 28, 2024 08:35
Copy link

github-actions bot commented Aug 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_quicksight_account_subscription: Add IAM Identity Center Instance ARN argument
3 participants