Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new resource] lakeformation_resource_lf_tag #36537

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 22, 2024

Description

Relations

Relates #36539

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccLakeFormation_serial/ResourceLFTag$" PKG=lakeformation

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/ResourceLFTag -timeout 360m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/ResourceLFTag
=== RUN   TestAccLakeFormation_serial/ResourceLFTag/basic
=== RUN   TestAccLakeFormation_serial/ResourceLFTag/disappears
=== RUN   TestAccLakeFormation_serial/ResourceLFTag/table
=== RUN   TestAccLakeFormation_serial/ResourceLFTag/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/database
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/disappears
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/hierarchy
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/table
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/basic
--- PASS: TestAccLakeFormation_serial (179.89s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTag (51.34s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/basic (14.99s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/disappears (11.51s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/table (12.33s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/tableWithColumns (12.51s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (128.55s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (20.71s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (19.32s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (11.24s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (24.03s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (21.15s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (21.09s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (11.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	185.725s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. generators Relates to code generators. labels Mar 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 22, 2024
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Mar 22, 2024
@johnsonaj johnsonaj marked this pull request as ready for review March 22, 2024 22:58
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTS="TestAccLakeFormation_serial/ResourceLFTag\$" PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/ResourceLFTag'  -timeout 360m

--- PASS: TestAccLakeFormation_serial (186.04s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTag (48.73s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/basic (11.68s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/disappears (12.07s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/table (12.46s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTag/tableWithColumns (12.51s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (137.32s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (19.80s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (21.16s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (13.11s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (26.22s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (22.34s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (22.44s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (12.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      191.774s

@@ -0,0 +1,104 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking - Might be worth including an Import heading just stating that import isn't supported for this resource?

@johnsonaj johnsonaj force-pushed the f-lakeformation_resource_lf_tag branch from c28b4e8 to 2e172d1 Compare March 25, 2024 14:43
@johnsonaj johnsonaj merged commit f04940d into main Mar 25, 2024
44 checks passed
@johnsonaj johnsonaj deleted the f-lakeformation_resource_lf_tag branch March 25, 2024 15:13
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 25, 2024
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants