resource/aws_db_instance: Adds warning when setting character_set_name on replica- or restore-type resources

[gdavison]

Description

The character_set_name parameter can only be set when creating a new DB instance. Adds a conflict warning when setting it when replicate_source_db, restore_to_point_in_time, or snapshot_identifier is set. It was already an error when setting it with s3_import.

Relations

Relates ##20379

Output from Acceptance Testing

% make testacc PKG=rds TESTS='TestAccRDSInstance_\w*characterSet'

    instance_test.go:2284: Skipping due to upstream error
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_characterSet (0.00s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica (2379.74s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Source (2422.93s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[jar-b]

LGTM 🎉

% make testacc PKG=rds TESTS='TestAccRDSInstance_\w*characterSet'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_\w*characterSet'  -timeout 360m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_characterSet_Source
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_characterSet_Source
=== RUN   TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica
=== RUN   TestAccRDSInstance_ReplicateSourceDB_CrossRegion_characterSet
    instance_test.go:2272: Skipping due to upstream error
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_CrossRegion_characterSet (0.00s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_characterSet_Source
=== CONT  TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Source (2608.34s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_characterSet_Replica (2632.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2637.914s

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.