Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_devopsguru_resource_collection: new resource #36489

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 20, 2024

Description

This resource will allow practitioners to manage Amazon DevOps Guru resource collections with Terraform. Resource collections are configured at the account level, so this resource should be configured only once to avoid competing definitions resulting in persistent differences.

Additional information can be found the in Amazon DevOps Guru User Guide:

https://docs.aws.amazon.com/devops-guru/latest/userguide/welcome.html

Relations

Relates #17919
Closes #36332

Depends on #36410
Relates #36437

References

Output from Acceptance Testing

% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/ResourceCollection/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/ResourceCollection/'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (104.94s)
    --- PASS: TestAccDevOpsGuru_serial/ResourceCollection (104.94s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/disappears (11.05s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/tags (11.20s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/tagsAllResources (11.25s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/basic (11.33s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/cloudformation (60.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 110.349s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. labels Mar 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 20, 2024
@jar-b jar-b force-pushed the f-devopsguru_resource_collection branch from 4d90957 to ad21714 Compare March 20, 2024 20:23
This resource will allow practitioners to manage Amazon DevOps Guru resource collections with Terraform. Resource collections are configured at the account level, so this resource should be configured only once to avoid competing definitions resulting in persistent differences. Additional information can be found the in Amazon DevOps Guru User Guide:

https://docs.aws.amazon.com/devops-guru/latest/userguide/welcome.html

```console
% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/ResourceCollection/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/ResourceCollection/'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (104.94s)
    --- PASS: TestAccDevOpsGuru_serial/ResourceCollection (104.94s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/disappears (11.05s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/tags (11.20s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/tagsAllResources (11.25s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/basic (11.33s)
        --- PASS: TestAccDevOpsGuru_serial/ResourceCollection/cloudformation (60.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 110.349s
```
@jar-b jar-b force-pushed the f-devopsguru_resource_collection branch from ad21714 to 34f0a6a Compare March 21, 2024 14:13
@jar-b jar-b merged commit df742ff into main Mar 21, 2024
44 checks passed
@jar-b jar-b deleted the f-devopsguru_resource_collection branch March 21, 2024 14:58
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 21, 2024
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 22, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_devopsguru_resource_collection
1 participant