Add support for database maintenance for FinSpace Kx Dataviews

[matthiasweaser]

Description

This pull request introduces two new parameters for FinSpace Kx Dataviews, read_write and on_demand, to enable users to conduct database maintenance on their dataviews.

Output from Acceptance Testing

make testacc TESTS=TestAccFinSpaceKxDataview_readWrite PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_readWrite'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_readWrite
=== PAUSE TestAccFinSpaceKxDataview_readWrite
=== CONT  TestAccFinSpaceKxDataview_readWrite
--- PASS: TestAccFinSpaceKxDataview_readWrite (1596.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1601.229s


make testacc TESTS=TestAccFinSpaceKxDataview_onDemand PKG=finspace 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_onDemand'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_onDemand
=== PAUSE TestAccFinSpaceKxDataview_onDemand
=== CONT  TestAccFinSpaceKxDataview_onDemand
--- PASS: TestAccFinSpaceKxDataview_onDemand (1592.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1596.833s
...

References

API documentation for these changes: https://docs.aws.amazon.com/finspace/latest/management-api/API_CreateKxDataview.html#finspace-CreateKxDataview-request-readWrite
User Guide: https://docs.aws.amazon.com/finspace/latest/userguide/finspace-managed-kdb-databases-dbmaint.html

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[matthiasweaser]

Acceptance Testing

make testacc TESTS=TestAccFinSpaceKxDataview_readWrite PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_readWrite'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_readWrite
=== PAUSE TestAccFinSpaceKxDataview_readWrite
=== CONT  TestAccFinSpaceKxDataview_readWrite
--- PASS: TestAccFinSpaceKxDataview_readWrite (1596.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1601.229s


make testacc TESTS=TestAccFinSpaceKxDataview_onDemand PKG=finspace 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_onDemand'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_onDemand
=== PAUSE TestAccFinSpaceKxDataview_onDemand
=== CONT  TestAccFinSpaceKxDataview_onDemand
--- PASS: TestAccFinSpaceKxDataview_onDemand (1592.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1596.833s
...

[jar-b]

LGTM 🎉

% make testacc PKG=finspace TESTS="TestAccFinSpaceKxDataview_readWrite|TestAccFinSpaceKxDataview_onDemand" ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxDataview_readWrite|TestAccFinSpaceKxDataview_onDemand'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_readWrite
=== PAUSE TestAccFinSpaceKxDataview_readWrite
=== RUN   TestAccFinSpaceKxDataview_onDemand
=== PAUSE TestAccFinSpaceKxDataview_onDemand
=== CONT  TestAccFinSpaceKxDataview_readWrite
--- PASS: TestAccFinSpaceKxDataview_readWrite (1502.57s)
=== CONT  TestAccFinSpaceKxDataview_onDemand
--- PASS: TestAccFinSpaceKxDataview_onDemand (1422.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   2930.683s

[jar-b]

Thanks for your contribution, @matthiasweaser! 🎸

[github-actions]

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.