aws_lb_target_group: always support ip_address_type

[arianvp]

Description

ip_address_type is supported for both type instance and type IP

Relations

Closes #35010

References

https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_CreateTargetGroup.html doesnt mention this only works for IP addresses. It also works for instances. I tested this in the EC2 Console where I Was able to create one with ipv6 support.

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @arianvp 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[svz-ya]

@justinretzolk Is there any chance that the proposed PR will be merged soon?
Thanks.

[arianvp]

Any update on this? I really would like this to be in. Anything I can do to make this easier to merge or review? Thanks

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2TargetGroup_ipAddressType\|TestAccELBV2TargetGroup_basic' PKG=elbv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2TargetGroup_ipAddressType\|TestAccELBV2TargetGroup_basic -timeout 360m
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== RUN   TestAccELBV2TargetGroup_ipAddressType
=== PAUSE TestAccELBV2TargetGroup_ipAddressType
=== CONT  TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_ipAddressType
--- PASS: TestAccELBV2TargetGroup_basic (18.07s)
--- PASS: TestAccELBV2TargetGroup_ipAddressType (18.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	22.842s

[ewbankkit]

@arianvp Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.