Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_vpc_peering_connection: Add IPv6 CIDR block attributes #36391

Conversation

finalduty
Copy link
Contributor

Description

Adds the ipv6_cidr_block_set and peer_ipv6_cidr_block_set attributes to the vpc_peering_connection data source.

Relations

Closes #25746

References

None

Output from Acceptance Testing

% make testacc TESTS=TestAccVPCPeeringConnectionDataSource_id PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCPeeringConnectionDataSource_id'  -timeout 360m
=== RUN   TestAccVPCPeeringConnectionDataSource_id
=== PAUSE TestAccVPCPeeringConnectionDataSource_id
=== CONT  TestAccVPCPeeringConnectionDataSource_id
--- PASS: TestAccVPCPeeringConnectionDataSource_id (58.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        76.192s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. size/S Managed by automation to categorize the size of a PR. labels Mar 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2024
@finalduty finalduty marked this pull request as ready for review March 15, 2024 00:28
@finalduty finalduty changed the title [WIP] d/aws_vpc_peering_connection: Add IPv6 CIDR block attributes d/aws_vpc_peering_connection: Add IPv6 CIDR block attributes Mar 15, 2024
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 15, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCPeeringConnectionDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCPeeringConnectionDataSource_ -timeout 360m
=== RUN   TestAccVPCPeeringConnectionDataSource_cidrBlock
=== PAUSE TestAccVPCPeeringConnectionDataSource_cidrBlock
=== RUN   TestAccVPCPeeringConnectionDataSource_id
=== PAUSE TestAccVPCPeeringConnectionDataSource_id
=== RUN   TestAccVPCPeeringConnectionDataSource_peerCIDRBlock
=== PAUSE TestAccVPCPeeringConnectionDataSource_peerCIDRBlock
=== RUN   TestAccVPCPeeringConnectionDataSource_peerVPCID
=== PAUSE TestAccVPCPeeringConnectionDataSource_peerVPCID
=== RUN   TestAccVPCPeeringConnectionDataSource_vpcID
=== PAUSE TestAccVPCPeeringConnectionDataSource_vpcID
=== CONT  TestAccVPCPeeringConnectionDataSource_cidrBlock
=== CONT  TestAccVPCPeeringConnectionDataSource_peerVPCID
--- PASS: TestAccVPCPeeringConnectionDataSource_peerVPCID (24.27s)
=== CONT  TestAccVPCPeeringConnectionDataSource_vpcID
--- PASS: TestAccVPCPeeringConnectionDataSource_cidrBlock (26.06s)
=== CONT  TestAccVPCPeeringConnectionDataSource_peerCIDRBlock
--- PASS: TestAccVPCPeeringConnectionDataSource_vpcID (23.26s)
=== CONT  TestAccVPCPeeringConnectionDataSource_id
--- PASS: TestAccVPCPeeringConnectionDataSource_peerCIDRBlock (27.00s)
--- PASS: TestAccVPCPeeringConnectionDataSource_id (33.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	92.974s

@ewbankkit
Copy link
Contributor

@finalduty Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 10beb8e into hashicorp:main Mar 20, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 20, 2024
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The aws_vpc_peering_connection datasource does not support IPv6 CIDR blocks
3 participants