Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Datasource for AWS Timestream Database #36368

Conversation

hunttom
Copy link
Contributor

@hunttom hunttom commented Mar 14, 2024

Description

This pull request creates a data resource for AWS Timestream Database.

Relations

Relates #26865

References

Output from Acceptance Testing

%  make fmt && make build && make testacc PKG=timestreamwrite TESTS=TestAccTimestreamWriteDatabaseDataSource
make: fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
==> Checking that code complies with gofmt requirements...
go1.21.8 install
make: build complete
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/timestreamwrite/... -v -count 1 -parallel 20 -run='TestAccTimestreamWriteDatabaseDataSource'  -timeout 360m
=== RUN   TestAccTimestreamWriteDatabaseDataSource_basic
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_basic
=== RUN   TestAccTimestreamWriteDatabaseDataSource_kmsKey
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_kmsKey
=== RUN   TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== RUN   TestAccTimestreamWriteDatabaseDataSource_tags
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_tags
=== CONT  TestAccTimestreamWriteDatabaseDataSource_basic
=== CONT  TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== CONT  TestAccTimestreamWriteDatabaseDataSource_kmsKey
=== CONT  TestAccTimestreamWriteDatabaseDataSource_tags
--- PASS: TestAccTimestreamWriteDatabaseDataSource_basic (13.62s)
--- PASS: TestAccTimestreamWriteDatabaseDataSource_kmsKey (18.20s)
--- PASS: TestAccTimestreamWriteDatabaseDataSource_tags (30.02s)
--- PASS: TestAccTimestreamWriteDatabaseDataSource_updateKMSKey (34.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite    40.186s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. generators Relates to code generators. labels Mar 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024
@hunttom hunttom changed the title Created datasource for AWS Timestream database [WIP] Created datasource for AWS Timestream database Mar 26, 2024
@hunttom hunttom changed the title [WIP] Created datasource for AWS Timestream database New Datasource for AWS Timestream Database Mar 27, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 27, 2024
@hunttom
Copy link
Contributor Author

hunttom commented Apr 22, 2024

@justinretzolk - Is there anything else needed to close this PR?

@justinretzolk
Copy link
Member

Hey @hunttom 👋 Thanks for checking in here! Based on a quick look, I don't believe there's any further action needed from you at this time. Unfortunately, I can't speak to when this will be prioritized just yet, though. We base our prioritization on the count of 👍 reactions and a few other considerations (more information: prioritization guide).

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner July 15, 2024 15:44
@ThomasZalewski
Copy link
Contributor

make testacc PKG=timestreamwrite TESTS=TestAccTimestreamWriteDatabaseDataSource

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/timestreamwrite/... -v -count 1 -parallel 20 -run='TestAccTimestreamWriteDatabaseDataSource' -timeout 360m
=== RUN TestAccTimestreamWriteDatabaseDataSource_basic
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_basic
=== RUN TestAccTimestreamWriteDatabaseDataSource_kmsKey
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_kmsKey
=== RUN TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== PAUSE TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== CONT TestAccTimestreamWriteDatabaseDataSource_basic
=== CONT TestAccTimestreamWriteDatabaseDataSource_updateKMSKey
=== CONT TestAccTimestreamWriteDatabaseDataSource_kmsKey
--- PASS: TestAccTimestreamWriteDatabaseDataSource_basic (11.40s)
--- PASS: TestAccTimestreamWriteDatabaseDataSource_kmsKey (17.46s)
--- PASS: TestAccTimestreamWriteDatabaseDataSource_updateKMSKey (33.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite 37.886s

@johnsonaj
Copy link
Contributor

LGTM 🚀

Copy link
Contributor

@ThomasZalewski ThomasZalewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ThomasZalewski ThomasZalewski merged commit 56be68d into hashicorp:main Jul 16, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 16, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants