fix: Add nil check for empty blocks to fix crashes for aws_ecs_cluster

[acwwat]

Description

This PR is to fix provider crashes in three locations due to empty configuration blocks (configuration, execute_command_configuration and log_configuration) being loaded as nil into the list of blocks from the config during expansion. The AWS API also seems to set a default value for the logging argument in the execute_command_configuration block, so I also had to set a default value to avoid perpetual differences.

Note: Since this is a widely used resource, I appreciate that a maintainer review this change to make sure I am not introducing any side effects. If there is anything I could do to help validate further, let me know.

Relations

Closes #36330

References

Referred to other resource code like that of aws_openserach_domain to see how similar cases are handled and follow suit.

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccECSCluster_" PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSCluster_ -timeout 360m
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_disappears
=== PAUSE TestAccECSCluster_disappears
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSCluster_serviceConnectDefaults
=== PAUSE TestAccECSCluster_serviceConnectDefaults
=== RUN   TestAccECSCluster_containerInsights
=== PAUSE TestAccECSCluster_containerInsights
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== CONT  TestAccECSCluster_basic
=== CONT  TestAccECSCluster_serviceConnectDefaults
=== CONT  TestAccECSCluster_tags
=== CONT  TestAccECSCluster_disappears
=== CONT  TestAccECSCluster_configuration
=== CONT  TestAccECSCluster_containerInsights
--- PASS: TestAccECSCluster_disappears (57.86s)
--- PASS: TestAccECSCluster_basic (59.06s)
--- PASS: TestAccECSCluster_tags (105.20s)
--- PASS: TestAccECSCluster_containerInsights (123.99s)
--- PASS: TestAccECSCluster_configuration (156.98s)
--- PASS: TestAccECSCluster_serviceConnectDefaults (211.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        211.836s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSCluster_configuration\|TestAccECSCluster_basic' PKG=ecs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 2  -run=TestAccECSCluster_configuration\|TestAccECSCluster_basic -timeout 360m
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== CONT  TestAccECSCluster_basic
=== CONT  TestAccECSCluster_configuration
--- PASS: TestAccECSCluster_basic (31.54s)
--- PASS: TestAccECSCluster_configuration (56.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	63.134s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.