Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Updating an aws_iot_topic_rule resource on temporary IAM exception #36286

Merged

Conversation

moonorange
Copy link
Contributor

@moonorange moonorange commented Mar 9, 2024

Description

Attempting to update an aws_iot_topic_rule resource in response to a temporary IAM exception.

Relations

Closes #33433

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented Mar 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 9, 2024
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Mar 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @moonorange 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 11, 2024
@ewbankkit ewbankkit marked this pull request as ready for review July 3, 2024 12:59
@ewbankkit ewbankkit requested a review from a team as a code owner July 3, 2024 12:59
@ewbankkit ewbankkit self-assigned this Jul 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoTTopicRule_s3' PKG=iot
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTTopicRule_s3 -timeout 360m
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== CONT  TestAccIoTTopicRule_s3
--- PASS: TestAccIoTTopicRule_s3 (33.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	37.876s

@ewbankkit
Copy link
Contributor

@moonorange Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 09df920 into hashicorp:main Jul 3, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Updating an aws_iot_topic_rule resource does not retry on temporary IAM exception
3 participants