r/medialive_channel: allow empty audio descriptions

[chrisandrews7]

Description

Audio descriptions are not actually required.
Useful for when you are creating a video only channel with no audio.

Relations

Relates #27824

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-medialive-channel-encodersettings.html#aws-properties-medialive-channel-encodersettings-properties

Output from Acceptance Testing

% make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 360m
=== RUN   TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN   TestAccMediaLiveChannel_captionDescriptions
=== PAUSE TestAccMediaLiveChannel_captionDescriptions
=== RUN   TestAccMediaLiveChannel_M2TS_settings
=== PAUSE TestAccMediaLiveChannel_M2TS_settings
=== RUN   TestAccMediaLiveChannel_UDP_outputSettings
=== PAUSE TestAccMediaLiveChannel_UDP_outputSettings
=== RUN   TestAccMediaLiveChannel_MsSmooth_outputSettings
=== PAUSE TestAccMediaLiveChannel_MsSmooth_outputSettings
=== RUN   TestAccMediaLiveChannel_AudioDescriptions_codecSettings
=== PAUSE TestAccMediaLiveChannel_AudioDescriptions_codecSettings
=== RUN   TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings
=== PAUSE TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings
=== RUN   TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
=== PAUSE TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
=== RUN   TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== RUN   TestAccMediaLiveChannel_noAudio
=== PAUSE TestAccMediaLiveChannel_noAudio
=== RUN   TestAccMediaLiveChannel_status
=== PAUSE TestAccMediaLiveChannel_status
=== RUN   TestAccMediaLiveChannel_update
=== PAUSE TestAccMediaLiveChannel_update
=== RUN   TestAccMediaLiveChannel_updateTags
=== PAUSE TestAccMediaLiveChannel_updateTags
=== RUN   TestAccMediaLiveChannel_disappears
=== PAUSE TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_basic
=== CONT  TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
=== CONT  TestAccMediaLiveChannel_update
=== CONT  TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_updateTags
=== CONT  TestAccMediaLiveChannel_noAudio
=== CONT  TestAccMediaLiveChannel_status
=== CONT  TestAccMediaLiveChannel_hls
=== CONT  TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings
=== CONT  TestAccMediaLiveChannel_MsSmooth_outputSettings
=== CONT  TestAccMediaLiveChannel_UDP_outputSettings
=== CONT  TestAccMediaLiveChannel_M2TS_settings
=== CONT  TestAccMediaLiveChannel_captionDescriptions
=== CONT  TestAccMediaLiveChannel_AudioDescriptions_codecSettings
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (89.93s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (106.42s)
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (107.26s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (117.68s)
--- PASS: TestAccMediaLiveChannel_hls (164.27s)
--- PASS: TestAccMediaLiveChannel_disappears (181.91s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (184.58s)
--- PASS: TestAccMediaLiveChannel_M2TS_settings (195.75s)
--- PASS: TestAccMediaLiveChannel_status (229.23s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (252.59s)
--- PASS: TestAccMediaLiveChannel_noAudio (271.53s)
--- PASS: TestAccMediaLiveChannel_update (275.12s)
--- PASS: TestAccMediaLiveChannel_updateTags (308.22s)
--- PASS: TestAccMediaLiveChannel_basic (321.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  322.015s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[chrisandrews7]

@jar-b Are you best to help with elemental based services please? As you approved #27075 prior

[jar-b]

LGTM 🎉

% make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 360m

--- PASS: TestAccMediaLiveChannel_noAudio (88.42s)
--- PASS: TestAccMediaLiveChannel_hls (89.34s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (95.60s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (95.98s)
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (103.87s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (165.65s)
--- PASS: TestAccMediaLiveChannel_basic (171.66s)
--- PASS: TestAccMediaLiveChannel_disappears (172.31s)
--- PASS: TestAccMediaLiveChannel_update (173.00s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (245.31s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (245.88s)
--- PASS: TestAccMediaLiveChannel_updateTags (251.40s)
--- PASS: TestAccMediaLiveChannel_M2TS_settings (253.88s)
--- PASS: TestAccMediaLiveChannel_status (312.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  316.913s

[jar-b]

Thanks for your contribution, @chrisandrews7 ! 👍

[github-actions]

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.