-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add vpc_id output of aws_elasticache_subnet_group data source #35887
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroupDataSource_\|TestAccElastiCacheSubnetGroup_' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3 -run=TestAccElastiCacheSubnetGroupDataSource_\|TestAccElastiCacheSubnetGroup_ -timeout 360m
=== RUN TestAccElastiCacheSubnetGroupDataSource_basic
=== PAUSE TestAccElastiCacheSubnetGroupDataSource_basic
=== RUN TestAccElastiCacheSubnetGroup_basic
=== PAUSE TestAccElastiCacheSubnetGroup_basic
=== RUN TestAccElastiCacheSubnetGroup_disappears
=== PAUSE TestAccElastiCacheSubnetGroup_disappears
=== RUN TestAccElastiCacheSubnetGroup_tags
=== PAUSE TestAccElastiCacheSubnetGroup_tags
=== RUN TestAccElastiCacheSubnetGroup_update
=== PAUSE TestAccElastiCacheSubnetGroup_update
=== CONT TestAccElastiCacheSubnetGroupDataSource_basic
=== CONT TestAccElastiCacheSubnetGroup_tags
=== CONT TestAccElastiCacheSubnetGroup_update
--- PASS: TestAccElastiCacheSubnetGroupDataSource_basic (38.00s)
=== CONT TestAccElastiCacheSubnetGroup_disappears
--- PASS: TestAccElastiCacheSubnetGroup_update (63.62s)
=== CONT TestAccElastiCacheSubnetGroup_basic
--- PASS: TestAccElastiCacheSubnetGroup_disappears (27.49s)
--- PASS: TestAccElastiCacheSubnetGroup_tags (80.22s)
--- PASS: TestAccElastiCacheSubnetGroup_basic (28.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 103.309s
@Jebaseelanravi Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
vpc_id
attr is missing in aws_elasticache_subnet_group data source.The
vpc_id
can be used for creating a security group of the ElastiCache cluster like the below.Affected Resource(s) and/or Data Source(s)
Relations
Closes #27398
References
Output from Acceptance Testing