Add eventual consistency protection on queue policy attributes

[Isaac-Bi]

Description

A dependency race condition occurs where the AWS API would sometimes return an ID instead of a correct ARN, resulting in an InvalidAttributeValue when trying to set the SQS Queue Policy. Adding a retry on applying the SQS Queue Policy results in fixing this eventual consistency bug.

Relations

Relates #21355
Relates #13980

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSQSQueuePolicy_basic' PKG_NAME=internal/service/sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueuePolicy_basic -timeout 360m
=== RUN   TestAccSQSQueuePolicy_basic
=== PAUSE TestAccSQSQueuePolicy_basic
=== CONT  TestAccSQSQueuePolicy_basic
--- PASS: TestAccSQSQueuePolicy_basic (96.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	103.314s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @Isaac-Bi 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[github-actions]

Welcome @Isaac-Bi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSQSQueuePolicy_' PKG=sqs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 3  -run=TestAccSQSQueuePolicy_ -timeout 360m
=== RUN   TestAccSQSQueuePolicy_basic
=== PAUSE TestAccSQSQueuePolicy_basic
=== RUN   TestAccSQSQueuePolicy_disappears
=== PAUSE TestAccSQSQueuePolicy_disappears
=== RUN   TestAccSQSQueuePolicy_Disappears_queue
=== PAUSE TestAccSQSQueuePolicy_Disappears_queue
=== RUN   TestAccSQSQueuePolicy_update
=== PAUSE TestAccSQSQueuePolicy_update
=== CONT  TestAccSQSQueuePolicy_basic
=== CONT  TestAccSQSQueuePolicy_Disappears_queue
=== CONT  TestAccSQSQueuePolicy_update
--- PASS: TestAccSQSQueuePolicy_basic (115.57s)
=== CONT  TestAccSQSQueuePolicy_disappears
--- PASS: TestAccSQSQueuePolicy_Disappears_queue (119.27s)
--- PASS: TestAccSQSQueuePolicy_update (147.15s)
--- PASS: TestAccSQSQueuePolicy_disappears (141.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	273.352s

[ewbankkit]

@Isaac-Bi Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.