Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: OpenSearch Ingestion Pipeline #35582

Merged
merged 22 commits into from
Feb 8, 2024

Conversation

farhanangullia
Copy link
Contributor

Description

New resource OpenSearch Ingestion pipeline (aws_osis_pipeline)

Relations

Closes #31364

References

Output from Acceptance Testing

% make testacc TESTS=TestAccOpenSearchIngestionPipeline PKG=osis
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/osis/... -v -count 1 -parallel 20 -run='TestAccOpenSearchIngestionPipeline'  -timeout 360m
=== RUN   TestAccOpenSearchIngestionPipeline_basic
=== PAUSE TestAccOpenSearchIngestionPipeline_basic
=== RUN   TestAccOpenSearchIngestionPipeline_disappears
=== PAUSE TestAccOpenSearchIngestionPipeline_disappears
=== RUN   TestAccOpenSearchIngestionPipeline_buffer
=== PAUSE TestAccOpenSearchIngestionPipeline_buffer
=== RUN   TestAccOpenSearchIngestionPipeline_encryption
=== PAUSE TestAccOpenSearchIngestionPipeline_encryption
=== RUN   TestAccOpenSearchIngestionPipeline_logPublishing
=== PAUSE TestAccOpenSearchIngestionPipeline_logPublishing
=== RUN   TestAccOpenSearchIngestionPipeline_vpc
=== PAUSE TestAccOpenSearchIngestionPipeline_vpc
=== RUN   TestAccOpenSearchIngestionPipeline_tags
=== PAUSE TestAccOpenSearchIngestionPipeline_tags
=== CONT  TestAccOpenSearchIngestionPipeline_basic
=== CONT  TestAccOpenSearchIngestionPipeline_disappears
=== CONT  TestAccOpenSearchIngestionPipeline_logPublishing
=== CONT  TestAccOpenSearchIngestionPipeline_vpc
=== CONT  TestAccOpenSearchIngestionPipeline_buffer
=== CONT  TestAccOpenSearchIngestionPipeline_tags
=== CONT  TestAccOpenSearchIngestionPipeline_encryption
--- PASS: TestAccOpenSearchIngestionPipeline_encryption (636.70s)
--- PASS: TestAccOpenSearchIngestionPipeline_disappears (670.12s)
--- PASS: TestAccOpenSearchIngestionPipeline_logPublishing (686.67s)
--- PASS: TestAccOpenSearchIngestionPipeline_basic (736.87s)
--- PASS: TestAccOpenSearchIngestionPipeline_vpc (787.69s)
--- PASS: TestAccOpenSearchIngestionPipeline_tags (834.19s)
--- PASS: TestAccOpenSearchIngestionPipeline_buffer (1574.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/osis       1610.667s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/osis Issues and PRs that pertain to the osis service. labels Jan 31, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 31, 2024
farhanangullia and others added 9 commits February 1, 2024 02:42
% make testacc TESTARGS='-run=TestAccOpenSearchIngestionPipeline_basic' PKG=osis
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/osis/... -v -count 1 -parallel 20  -run=TestAccOpenSearchIngestionPipeline_basic -timeout 360m
=== RUN   TestAccOpenSearchIngestionPipeline_basic
=== PAUSE TestAccOpenSearchIngestionPipeline_basic
=== CONT  TestAccOpenSearchIngestionPipeline_basic
--- PASS: TestAccOpenSearchIngestionPipeline_basic (602.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/osis	630.121s
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 8, 2024
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchIngestionPipeline_' PKG=osis ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/osis/... -v -count 1 -parallel 2  -run=TestAccOpenSearchIngestionPipeline_ -timeout 360m
=== RUN   TestAccOpenSearchIngestionPipeline_basic
=== PAUSE TestAccOpenSearchIngestionPipeline_basic
=== RUN   TestAccOpenSearchIngestionPipeline_disappears
=== PAUSE TestAccOpenSearchIngestionPipeline_disappears
=== RUN   TestAccOpenSearchIngestionPipeline_buffer
=== PAUSE TestAccOpenSearchIngestionPipeline_buffer
=== RUN   TestAccOpenSearchIngestionPipeline_encryption
=== PAUSE TestAccOpenSearchIngestionPipeline_encryption
=== RUN   TestAccOpenSearchIngestionPipeline_logPublishing
=== PAUSE TestAccOpenSearchIngestionPipeline_logPublishing
=== RUN   TestAccOpenSearchIngestionPipeline_vpc
=== PAUSE TestAccOpenSearchIngestionPipeline_vpc
=== RUN   TestAccOpenSearchIngestionPipeline_tags
=== PAUSE TestAccOpenSearchIngestionPipeline_tags
=== CONT  TestAccOpenSearchIngestionPipeline_basic
=== CONT  TestAccOpenSearchIngestionPipeline_logPublishing
--- PASS: TestAccOpenSearchIngestionPipeline_basic (594.49s)
=== CONT  TestAccOpenSearchIngestionPipeline_tags
--- PASS: TestAccOpenSearchIngestionPipeline_logPublishing (667.90s)
=== CONT  TestAccOpenSearchIngestionPipeline_buffer
=== CONT  TestAccOpenSearchIngestionPipeline_encryption
--- PASS: TestAccOpenSearchIngestionPipeline_tags (840.64s)
--- PASS: TestAccOpenSearchIngestionPipeline_encryption (763.34s)
=== CONT  TestAccOpenSearchIngestionPipeline_disappears
--- PASS: TestAccOpenSearchIngestionPipeline_buffer (1611.14s)
=== CONT  TestAccOpenSearchIngestionPipeline_vpc
--- PASS: TestAccOpenSearchIngestionPipeline_disappears (643.79s)
--- PASS: TestAccOpenSearchIngestionPipeline_vpc (651.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/osis	2962.152s

@ewbankkit
Copy link
Contributor

@farhanangullia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 724451e into hashicorp:main Feb 8, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/osis Issues and PRs that pertain to the osis service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: OpenSearch Ingestion Pipeline
2 participants