-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lakeformation_resource: add hybrid_access_enabled argument #35571
r/aws_lakeformation_resource: add hybrid_access_enabled argument #35571
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @prithvi514 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
# Conflicts: # internal/service/lakeformation/resource.go # internal/service/lakeformation/resource_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLakeFormationResource_' PKG=lakeformation ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 2 -run=TestAccLakeFormationResource_ -timeout 360m
=== RUN TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== RUN TestAccLakeFormationResource_disappears
=== PAUSE TestAccLakeFormationResource_disappears
=== RUN TestAccLakeFormationResource_serviceLinkedRole
=== PAUSE TestAccLakeFormationResource_serviceLinkedRole
=== RUN TestAccLakeFormationResource_updateRoleToRole
=== PAUSE TestAccLakeFormationResource_updateRoleToRole
=== RUN TestAccLakeFormationResource_updateSLRToRole
=== PAUSE TestAccLakeFormationResource_updateSLRToRole
=== RUN TestAccLakeFormationResource_hybridAccessEnabled
=== PAUSE TestAccLakeFormationResource_hybridAccessEnabled
=== CONT TestAccLakeFormationResource_basic
=== CONT TestAccLakeFormationResource_updateRoleToRole
--- PASS: TestAccLakeFormationResource_basic (24.45s)
=== CONT TestAccLakeFormationResource_hybridAccessEnabled
--- PASS: TestAccLakeFormationResource_updateRoleToRole (41.10s)
=== CONT TestAccLakeFormationResource_updateSLRToRole
--- PASS: TestAccLakeFormationResource_hybridAccessEnabled (22.61s)
=== CONT TestAccLakeFormationResource_serviceLinkedRole
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (21.66s)
=== CONT TestAccLakeFormationResource_disappears
--- PASS: TestAccLakeFormationResource_updateSLRToRole (40.24s)
--- PASS: TestAccLakeFormationResource_disappears (22.54s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation 102.310s
This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This argument will allow users to configure the value of
HybridAccessEnabled
parameter boolean in the underlying AWS RegisterResource API. Users can then register S3 data location in Hybrid access mode.Relations
Closes #35548
References
https://docs.aws.amazon.com/lake-formation/latest/APIReference/API_RegisterResource.html
Output from Acceptance Testing