-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'timeout' attribute to Glue Trigger create, update and delete #35542
Add 'timeout' attribute to Glue Trigger create, update and delete #35542
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @MSilva98 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hello. I am working in the same project as this PR Author. Here is the execution of only the basic test - TestAccGlueTrigger_basic:
Please tell us if we need to run acc tests for something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccGlueTrigger_' PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlueTrigger_ -timeout 360m
--- PASS: TestAccGlueTrigger_tags (56.85s)
--- PASS: TestAccGlueTrigger_onDemandDisable (70.56s)
--- PASS: TestAccGlueTrigger_Actions_notify (79.78s)
--- PASS: TestAccGlueTrigger_Actions_security (80.01s)
--- PASS: TestAccGlueTrigger_basic (84.37s)
--- PASS: TestAccGlueTrigger_startOnCreate (90.30s)
--- PASS: TestAccGlueTrigger_workflowName (96.81s)
--- PASS: TestAccGlueTrigger_disappears (115.06s)
--- PASS: TestAccGlueTrigger_predicate (138.70s)
--- PASS: TestAccGlueTrigger_eventBatchingCondition (151.48s)
--- PASS: TestAccGlueTrigger_schedule (152.96s)
--- PASS: TestAccGlueTrigger_crawler (177.99s)
--- PASS: TestAccGlueTrigger_enabled (190.28s)
--- PASS: TestAccGlueTrigger_description (238.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 246.158s
@MSilva98 thank you for the contribution! 🎉 |
This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add timeout attribute to glue triggers according to the documentation
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/glue_trigger#timeouts
Output from Acceptance Testing
I cannot run the acceptance tests on my side. Please let me know if there are any changes I can/need to make.