Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fis_expermient_template: remove validation for target properties #35254

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Resource type aws:eks:pod can be created in a target and does not require resource_arns or resource_tags. Remove validation to allow operation to complete.

resource "aws_fis_experiment_template" "test" {
  description = "test"
  role_arn    = aws_iam_role.test.arn

  stop_condition {
    source = "none"
  }

  action {
    name        = "Memory-Stress-1"
    action_id   = "aws:eks:pod-memory-stress"
    description = "EKS token service memory stress"

    parameter {
      key   = "duration"
      value = "PT15M"
    }

    parameter {
      key   = "kubernetesServiceAccount"
      value = "fis-experiment"
    }

    target {
      key   = "Pods"
      value = "Pod-Target-1"
    }
  }

  target {
    name           = "Pod-Target-1"
    resource_type  = "aws:eks:pod"
    selection_mode = "ALL"

    parameters = {
      "clusterIdentifier" = "test"
      "namespace"         = "default"
      "selectorType"      = "labelSelector"
      "selectorValue"     = "app=nginx"
    }
  }
}

Relations

Closes #32281

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccFISExperimentTemplate_' PKG=fis

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 20  -run=TestAccFISExperimentTemplate_ -timeout 360m
--- PASS: TestAccFISExperimentTemplate_spot (14.58s)
--- PASS: TestAccFISExperimentTemplate_disappears (14.97s)
--- PASS: TestAccFISExperimentTemplate_basic (17.04s)
--- PASS: TestAccFISExperimentTemplate_update (25.43s)
--- PASS: TestAccFISExperimentTemplate_ebsParameters (35.68s)
--- PASS: TestAccFISExperimentTemplate_ebs (35.70s)
--- PASS: TestAccFISExperimentTemplate_loggingConfiguration (46.57s)
--- PASS: TestAccFISExperimentTemplate_eks (616.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fis	620.270s.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/fis Issues and PRs that pertain to the fis service. labels Jan 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 11, 2024
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Jan 11, 2024
@johnsonaj johnsonaj force-pushed the b-fis_experiment_template_validation branch from 5235971 to 787f419 Compare January 12, 2024 15:37
@johnsonaj johnsonaj merged commit 49f1814 into main Jan 12, 2024
34 checks passed
@johnsonaj johnsonaj deleted the b-fis_experiment_template_validation branch January 12, 2024 19:34
@github-actions github-actions bot added this to the v5.33.0 milestone Jan 12, 2024
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Jan 18, 2024
Copy link

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/fis Issues and PRs that pertain to the fis service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fault Injection Experiment Template[Enhancement]:
2 participants